@SNowick_WMF - Would like to talk with you about testing these out as a possible retention mechanism.

Hi Charlotte-
Let's discuss in our next meeting, we just need to archive the data so we
have a historical record to measure retention. Will these only be shown to
new users?
I've added this to our meeting notes doc.
https://docs.google.com/document/d/1m1gn0HKJNIjlwsKFMHGmZQW6g9ztODHR7WBAtULlW2M/edit?usp=sharing

Hi @schoenbaechler, I'd like to claim the ticket but not sure if it is ready for dev since you are still claiming the ticket.

and I've also noticed the image in the center does not contain the small parts around it, is it possible to combine the elements to be as one single SVG file to reduce the complexity of implementation?

@cooltey, yeah go ahead with it, I’ll prepare the correct graphics next week!

Hi @schoenbaechler

Contributions:
Starting at the 5th contribution, shown after every 50th additional contribution, (5, 55, 105 and so forth)

The text of the screen in Zeplin is Wow, that was your fifth contribution to Wikipedia with Suggested edits., can we make the fifth to 5th, which is a number with the suffix?

Hey @cooltey, we can definitely do that. I’m wondering if that solves the issue of the translation into other strings though? Should we aim for something that works more robust across languages, like:

«Wow, that makes 5 contributions to Wikipedia with Suggested edits.»

What do you think @Charlotte in regards to the language itself? Also interested in what @Dbrant thinks about the sentence’s suitability to be translated into other languages.

• "Wow, that is your fifth contribution..."

Ordinal numbers are incredibly tricky to translate, especially in context of a larger sentence. Your suggestion of "Wow, that makes 5 contributions..." is better.
Also, just my opinion, but saying "Wow!" for 5 contributions seems a bit infantilizing.

• "You're on an edit streak of ten days..."

Similarly, it would be better to change this to a numeral "10".

• "Your edits have earned 1898 pageviews..."

Have they, though? I think the pageviews were probably "earned" by the original editors of the article. Wouldn't it be more accurate to say, "Your edits have been seen by 1898 visitors"? (which also ditches the "pageviews" terminology)

Unrelated question: What are the "back" and "forward" arrows at the bottom of the interstitial screens? (or within Zeplin, the "down" and "forward" arrows)

Agree with your suggestions @Dbrant.

Unrelated question: What are the "back" and "forward" arrows at the bottom of the interstitial screens? (or within Zeplin, the "down" and "forward" arrows)

The down arrow was a mistake in the visuals. I thought it’d be good to keep the swipe gesture/user expectation consistent, even when this is interstitial is shown to not interrupt the flow. The arrows symbolize that you can still swipe left to go to the next suggestion or swipe right to go back.

@cooltey updated the screens on Zeplin – all illustrations are one unit now. Keep in mind that for edit quality, the illustration should adapt to the actual value of edit quality:

• Shown every 14 days when revert rate is “Perfect“, “Excellent“, “Very good“ or “Good“, when user has actively contributed in the past 14 days (at least one edit)

Hi @schoenbaechler

I am still seeing the old screens and texts on Zeplin. Could you please check if the materials were uploaded correctly?

Keep in mind that for edit quality, the illustration should adapt to the actual value of edit quality.

Is it possible to provide the different version of edit quality images?

@cooltey

I am still seeing the old screens and texts on Zeplin. Could you please check if the materials were uploaded correctly?

They should be updated now! 👍

Is it possible to provide the different version of edit quality images?

Done & added!

Thanks @schoenbaechler

I have issues when importing these three SVG files to the Android vector files and the files will look like the "perfect edit quality" one, although the previews on the Zeplin are different.

The png files are looking great, and not sure why the SVG files are not.

https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5eb08df4de36cd1a4083646b
https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5eb08df4b7bd22b0d507339b
https://app.zeplin.io/project/57a120b91998d8977642a238/screen/5eb08df5c9476f1b41704759

@cooltey: some updated text in light of @Dbrant's suggestions, as promised:

Your edits so far are [level]. Keep going! We look forward to your contributions.

You've made [n] contributions to Wikipedia using Suggested edits. Thank you!

You've edited every day for [x] days so far. Keep the streak going, [name]!

Your edits have been seen by [x] people in the last 30 days. Thanks, and keep going!

Thanks @Charlotte.

@schoenbaechler I have a question about the logic of showing the contribution card:

What if the user is about to reach the 105th contribution when the user submitting the first edit in this session, should we still show the card after the user's second edit in the session?

SE feed (104th edits) -> add description cards screen (104th edits) -> submit (1st edit in the session) -> add description cards screen (105 edits) -> submit (2nd edit in the session) -> add description cards screen (106 edits) -> see reward interstitial?

Good question @cooltey, can we add an additional rule like this: if a user starts a session, an interstitial is shown earliest after the 5th contribution? I feel like it might be disruptive if it appears after the first or second edit already.

In T241847#6112065, @schoenbaechler wrote:

Good question @cooltey, can we add an additional rule like this: if a user starts a session, an interstitial is shown earliest after the 5th contribution? I feel like it might be disruptive if it appears after the first or second edit already.

We do not have very many sessions that make it to 5 edits - less than 2% of sessions. So if the interstitials are going to show at all, they will need to be after the 2nd edit.

@Charlotte, interesting! Can you point me to more stats like this?

In T241847#6112554, @schoenbaechler wrote:

@Charlotte, interesting! Can you point me to more stats like this?

They're all on the dashboard report.

Thanks @schoenbaechler and @Charlotte. I'll keep the current logic of showing the reward interstitial that shows after the 2nd edit. If the user reaches the conditions before 2nd edits, the message will be held and showed after the 2nd edits.

@cooltey just tried it out! I’ll provide illustrations for light and sepia tomorrow as it doesn’t look 100% appropriate yet (see screenshot below)

@cooltey do we have any options to play a certain success sound (and vibration) if this shows up? I think it’d be awesome!

In T241847#6217178, @schoenbaechler wrote:

@cooltey do we have any options to play a certain success sound (and vibration) if this shows up? I think it’d be awesome!

We definitely can play sound with vibration if the cards show up.

@cooltey

We definitely can play sound with vibration if the cards show up.

Can we access the device’s default system sounds? I suggest to use the default vibration and sound of “new message” for this. Possible? If yes, let’s do it. Otherwise open to suggestions.

Another important aspect → respect the user’s settings, e.g. if the device’s is set to silent or vibration only.

@cooltey I added light variants of to Zeplin:

https://app.zeplin.io/project/57a120b91998d8977642a238/dashboard?seid=5e0f67c01268d6160f888586

Light variants of the illus should be applied in Light and Sepia reading theme. Dark variants of the illus in Dark + Black reading theme.

Thx!

In T241847#6218319, @schoenbaechler wrote:

@cooltey

We definitely can play sound with vibration if the cards show up.

Can we access the device’s default system sounds? I suggest to use the default vibration and sound of “new message” for this. Possible? If yes, let’s do it. Otherwise open to suggestions.

Another important aspect → respect the user’s settings, e.g. if the device’s is set to silent or vibration only.

Yes we can do it. (same vibration in image tag + default notification sound)

Light variants of the illus should be applied in Light and Sepia reading theme. Dark variants of the illus in Dark + Black reading theme.

Done

@cooltey

01) Dark modes are using the wrong illustrations, could you double check if they’re using the latest from Zeplin?

02) Also, I noticed that the copy is different from the screens on Zeplin → is this intentional? Thx for claryfing.

@cooltey, if you feel inspired → just got reminded of the onboarding animations on iOS, which are super nice 👇

https://www.dropbox.com/s/d638lbl843at55o/RPReplay_Final1592323200.mp4?dl=0

In T241847#6227835, @schoenbaechler wrote:

@cooltey

01) Dark modes are using the wrong illustrations, could you double check if they’re using the latest from Zeplin?

I removed the old ones and imported the new illustrations to the project, they should be the latest ones. Please try to download the latest Alpha again to make sure you can see the changes.

02) Also, I noticed that the copy is different from the screens on Zeplin → is this intentional? Thx for claryfing.

We had a discussion in the previous comments, and that's from Charlotte's suggestion:
https://phabricator.wikimedia.org/T241847#6109102

if you feel inspired → just got reminded of the onboarding animations on iOS, which are super nice 👇

Sure! Is it possible to provide an AnimateVector? if so, we can try to put that into our onboarding screen.
https://developer.android.com/reference/android/graphics/drawable/AnimatedVectorDrawable

@cooltey

I removed the old ones and imported the new illustrations to the project, they should be the latest ones. Please try to download the latest Alpha again to make sure you can see the changes.

Looks good to me now.

We had a discussion in the previous comments, and that's from Charlotte's suggestion:
https://phabricator.wikimedia.org/T241847#6109102

Ah, yes, that’s fine then – just wanted to make sure.

if you feel inspired → just got reminded of the onboarding animations on iOS, which are super nice 👇

Sure! Is it possible to provide an AnimateVector? if so, we can try to put that into our onboarding screen.
https://developer.android.com/reference/android/graphics/drawable/AnimatedVectorDrawable

Ok, I’ll experiment a bit with https://shapeshifter.design/. But it shouldn’t be a blocker for this task!

→ Feel free to move this to QA signoff if all’s good from your end @cooltey.

Ok, I’ll experiment a bit with https://shapeshifter.design/. But it shouldn’t be a blocker for this task!

Sounds good to me, thanks @schoenbaechler

@cooltey or @schoenbaechler - Is there a way to force these to appear? I was hoping to check all the screens on all the themes. Thanks

Great input, since I only checked a few @ABorbaWMF. It would be great to review them all. @cooltey can definitely help!

@ABorbaWMF and @schoenbaechler I've created a PR for it and it is waiting for code review now. Will let you know when it's merged.

@schoenbaechler and @ABorbaWMF The PR is merged and you can find the preference setting at the bottom of the developer preferences list.

Looks good to me on 2.7.50322-alpha-2020-06-22 using the developer settings to view in all themes. I'll leave the ticket here for @schoenbaechler to check

looks good @cooltey → one minor thing 👇

01) Set text color to primary_text_color / color_group_5 (different than e.g. in onboarding dialogs)

Thx!

Ready for signoff I think!