Page MenuHomePhabricator
Create Task
Maniphest T241880

References are not visually highlighted when they are a part of a larger text selection
Closed, ResolvedPublic
Actions

Assigned To
matmarex
Authored By
matmarex
Jan 4 2020, 12:59 PM
Tags
Referenced Files
F31500230: image.png
Jan 4 2020, 1:11 PM
F31500232: image.png
Jan 4 2020, 1:11 PM
F31500221: image.png
Jan 4 2020, 1:11 PM
F31500242: image.png
Jan 4 2020, 1:11 PM
F31500244: image.png
Jan 4 2020, 1:11 PM
F31500240: image.png
Jan 4 2020, 1:11 PM
F31500224: image.png
Jan 4 2020, 1:11 PM
F31500234: image.png
Jan 4 2020, 1:11 PM
View All 12 Files
Subscribers
Aklapper
matmarex

Description

Mentioned in T241678:

Note that in the Visual Editor the selection of a citation at the end of the sentence is not visually highlighted so missing it can easily happen (aside, could this please be fixed!).

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Citemaster+11 -4Make native selection over reference nodes visible
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Jan 4 2020, 12:59 PM
Restricted Application added a project: VisualEditor. · View Herald TranscriptJan 4 2020, 12:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jan 4 2020, 1:01 PM

Change 561977 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Cite@master] Make native selection over reference nodes visible

https://gerrit.wikimedia.org/r/561977

gerritbot added a project: Patch-For-Review.Jan 4 2020, 1:01 PM
matmarex added a comment.Jan 4 2020, 1:11 PM

There are some minor graphical glitches (particularly in Chromium), but this still seems like a big improvement to me.

ChromiumFirefoxEdge
Before
image.png (2×3 px, 307 KB)
image.png (2×3 px, 315 KB)
image.png (2×3 px, 338 KB)
image.png (2×3 px, 344 KB)
image.png (2×3 px, 291 KB)
image.png (2×3 px, 293 KB)
After
image.png (2×3 px, 307 KB)
image.png (2×3 px, 316 KB)
image.png (2×3 px, 337 KB)
image.png (2×3 px, 344 KB)
image.png (2×3 px, 291 KB)
image.png (2×3 px, 293 KB)
matmarex mentioned this in T241678: Visual Editor unable to copy and paste a citation between articles.Jan 4 2020, 1:12 PM
matmarex claimed this task.Jan 4 2020, 3:19 PM
matmarex mentioned this in T196986: CX2: Text selection breaks when there is a citation in the middle.
matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Jan 4 2020, 3:24 PM
matmarex moved this task from Incoming to Code review on the VisualEditor (Current work) board.Jan 4 2020, 3:26 PM
Izno moved this task from Unsorted backlog to External on the Cite board.Jan 7 2020, 10:54 PM
gerritbot added a comment.Jan 8 2020, 4:31 PM

Change 561977 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Make native selection over reference nodes visible

https://gerrit.wikimedia.org/r/561977

matmarex mentioned this in rECIT52646d1a7c96: Make native selection over reference nodes visible.Jan 8 2020, 4:32 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 8 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 8 2020, 5:10 PM
Esanders moved this task from Code review to QA on the VisualEditor (Current work) board.Jan 8 2020, 9:58 PM
Ryasmeen added a project: Editing QA.Jan 10 2020, 11:44 PM
Ryasmeen edited projects, added Verified; removed Editing QA.Jan 14 2020, 1:03 AM
Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.
• ppelberg closed this task as Resolved.Jan 21 2020, 1:59 AM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL