Page MenuHomePhabricator

References are not visually highlighted when they are a part of a larger text selection
Closed, ResolvedPublic

Assigned To
Authored By
matmarex
Jan 4 2020, 12:59 PM
Referenced Files
F31500230: image.png
Jan 4 2020, 1:11 PM
F31500232: image.png
Jan 4 2020, 1:11 PM
F31500221: image.png
Jan 4 2020, 1:11 PM
F31500242: image.png
Jan 4 2020, 1:11 PM
F31500244: image.png
Jan 4 2020, 1:11 PM
F31500240: image.png
Jan 4 2020, 1:11 PM
F31500224: image.png
Jan 4 2020, 1:11 PM
F31500234: image.png
Jan 4 2020, 1:11 PM
Subscribers

Description

Mentioned in T241678:

Note that in the Visual Editor the selection of a citation at the end of the sentence is not visually highlighted so missing it can easily happen (aside, could this please be fixed!).

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 561977 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Cite@master] Make native selection over reference nodes visible

https://gerrit.wikimedia.org/r/561977

There are some minor graphical glitches (particularly in Chromium), but this still seems like a big improvement to me.

ChromiumFirefoxEdge
Before
image.png (2×3 px, 307 KB)
image.png (2×3 px, 315 KB)
image.png (2×3 px, 338 KB)
image.png (2×3 px, 344 KB)
image.png (2×3 px, 291 KB)
image.png (2×3 px, 293 KB)
After
image.png (2×3 px, 307 KB)
image.png (2×3 px, 316 KB)
image.png (2×3 px, 337 KB)
image.png (2×3 px, 344 KB)
image.png (2×3 px, 291 KB)
image.png (2×3 px, 293 KB)

Change 561977 merged by jenkins-bot:
[mediawiki/extensions/Cite@master] Make native selection over reference nodes visible

https://gerrit.wikimedia.org/r/561977