Page MenuHomePhabricator
Create Task
Maniphest T241903

TimedMediaHandler needs uses of global $wgUser removed
Closed, ResolvedPublic
Actions

Description

See parent task

Codesearch: https://codesearch.wmcloud.org/deployed/?q=wgUser(%5B%3B%2C%27%22-%5D%7C%5Cs%7C%24)&i=nope&files=%5C.php%24&repos=mediawiki/extensions/TimedMediaHandler

Details

SubjectRepoBranchLines +/-
TimedMediaHandlerHooks: remove last use of global $wgUsermediawiki/extensions/TimedMediaHandlermaster+1 -3
Remove some uses of global $wgUser and global $wgOutmediawiki/extensions/TimedMediaHandlermaster+10 -11
Remove use of $wgUser in ApiVideoUploadTestCasemediawiki/extensions/TimedMediaHandlermaster+5 -4
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 triaged this task as Medium priority.Jan 4 2020, 9:30 PM
DannyS712 created this task.
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 4 2020, 9:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jan 4 2020, 9:31 PM

Change 562006 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TimedMediaHandler@master] Remove some uses of global $wgUser

https://gerrit.wikimedia.org/r/562006

gerritbot added a project: Patch-For-Review.Jan 4 2020, 9:31 PM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Jan 4 2020, 9:36 PM
DannyS712 mentioned this in T159299: Deprecate and remove $wgUser.Jan 28 2020, 8:50 PM
DannyS712 added a parent task: T245959: WMF deployed extensions need uses of global $wgUser removed [tracking].Feb 23 2020, 10:29 PM
DannyS712 removed a parent task: T159299: Deprecate and remove $wgUser.
TheDJ changed the task status from Open to Stalled.Feb 24 2020, 9:28 AM
gerritbot added a comment.Sep 3 2020, 7:34 PM

Change 562006 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Remove some uses of global $wgUser and global $wgOut

https://gerrit.wikimedia.org/r/562006

Maintenance_bot removed a project: Patch-For-Review.Sep 3 2020, 8:11 PM
gerritbot added a comment.Sep 13 2020, 10:52 PM

Change 626896 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/TimedMediaHandler@master] Remove use of $wgUser in ApiVideoUploadTestCase

https://gerrit.wikimedia.org/r/626896

gerritbot added a project: Patch-For-Review.Sep 13 2020, 10:52 PM
DannyS712 added a project: Platform Team Workboards (External Code Reviews).Sep 13 2020, 10:53 PM
gerritbot added a comment.Sep 14 2020, 4:49 AM

Change 626896 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Remove use of $wgUser in ApiVideoUploadTestCase

https://gerrit.wikimedia.org/r/626896

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 14 2020, 5:00 AM
DannyS712 updated the task description. (Show Details)Sep 14 2020, 5:04 AM
• AMooney moved this task from External Code Review Needed to External Code Review Completed on the Platform Team Workboards (External Code Reviews) board.Apr 14 2021, 8:04 PM
DannyS712 changed the task status from Stalled to Open.Jun 24 2021, 1:19 PM
DannyS712 moved this task from External Code Review Completed to External Code Review Needed on the Platform Team Workboards (External Code Reviews) board.
gerritbot added a comment.Jun 24 2021, 1:20 PM

Change 701284 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/TimedMediaHandler@master] TimedMediaHandlerHooks: remove last use of global $wgUser

https://gerrit.wikimedia.org/r/701284

Jdforrester-WMF closed this task as Resolved.Jun 28 2021, 1:22 PM
TheDJ subscribed.Jun 28 2021, 1:25 PM

Thank you @DannyS712

gerritbot added a comment.Jun 28 2021, 2:06 PM

Change 701284 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] TimedMediaHandlerHooks: remove last use of global $wgUser

https://gerrit.wikimedia.org/r/701284

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jun 28 2021, 3:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL