Page MenuHomePhabricator
Create Task
Maniphest T241915

Jade needs uses of global $wgUser removed
Closed, ResolvedPublic
Actions

Description

See parent task

Codesearch: https://codesearch.wmcloud.org/deployed/?q=wgUser(%5B%3B%2C%27%22-%5D%7C%5Cs%7C%24)&i=nope&files=%5C.php%24&repos=mediawiki/extensions/Jade

Details

SubjectRepoBranchLines +/-
Remove uses of $wgUser in PageEntityProposalSetStorageTestmediawiki/extensions/Jademaster+2 -18
Remove TestStorageHelper::saveJudgment use of $wgUsermediawiki/extensions/Jademaster+40 -23
Remove TestStorageHelper::makeEdit use of $wgUsermediawiki/extensions/Jademaster+55 -10
TestStorageHelper: Replace saveJudgment with updateJudgementmediawiki/extensions/Jademaster+0 -0
TestStorageHelper: Replace createEntity with createNewEntitymediawiki/extensions/Jademaster+132 -92
Remove unused classes and testsmediawiki/extensions/Jademaster+0 -428
Remove use of global $wgUser (part 2)mediawiki/extensions/Jademaster+10 -6
Add constructor for EntityBuilder to pass a usermediawiki/extensions/Jademaster+29 -31
Remove use of global $wgUser (part 1)mediawiki/extensions/Jademaster+47 -42
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 triaged this task as Medium priority.Jan 5 2020, 4:49 AM
DannyS712 created this task.
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 5 2020, 4:49 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Jan 5 2020, 4:51 AM

Change 562020 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Remove use of global $wgUser (part 1)

https://gerrit.wikimedia.org/r/562020

gerritbot added a project: Patch-For-Review.Jan 5 2020, 4:51 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Jan 5 2020, 5:02 AM
gerritbot added a comment.Jan 13 2020, 3:31 AM

Change 562020 abandoned by DannyS712:
Remove use of global $wgUser (part 1)

Reason:
Doing differently, cannot rebase

https://gerrit.wikimedia.org/r/562020

gerritbot added a comment.Jan 13 2020, 3:33 AM

Change 563762 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Add constructor for EntityBuilder to pass a user

https://gerrit.wikimedia.org/r/563762

gerritbot added a comment.Jan 18 2020, 7:18 PM

Change 563762 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Add constructor for EntityBuilder to pass a user

https://gerrit.wikimedia.org/r/563762

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 18 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 18 2020, 8:10 PM
DannyS712 mentioned this in T159299: Deprecate and remove $wgUser.Jan 28 2020, 8:50 PM
gerritbot added a comment.Feb 1 2020, 1:48 AM

Change 569295 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Remove use of global $wgUser (part 2)

https://gerrit.wikimedia.org/r/569295

gerritbot added a project: Patch-For-Review.Feb 1 2020, 1:48 AM
gerritbot added a comment.Feb 1 2020, 7:51 AM

Change 569295 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Remove use of global $wgUser (part 2)

https://gerrit.wikimedia.org/r/569295

Maintenance_bot removed a project: Patch-For-Review.Feb 1 2020, 8:10 AM
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.18; 2020-02-04); removed MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Feb 1 2020, 12:00 PM
gerritbot added a comment.Feb 7 2020, 10:56 PM

Change 570962 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Remove unused PageEntityJudgmentSetStorageTest

https://gerrit.wikimedia.org/r/570962

gerritbot added a project: Patch-For-Review.Feb 7 2020, 10:57 PM
DannyS712 added a parent task: T245959: WMF deployed extensions need uses of global $wgUser removed [tracking].Feb 23 2020, 10:29 PM
DannyS712 removed a parent task: T159299: Deprecate and remove $wgUser.
gerritbot added a comment.Apr 15 2020, 6:46 PM

Change 570962 abandoned by DannyS712:
Remove unused classes and tests

Reason:
I just wanted to remove the use of $wgUser - will resubmit that part later

https://gerrit.wikimedia.org/r/570962

Maintenance_bot removed a project: Patch-For-Review.Apr 15 2020, 7:10 PM
gerritbot added a comment.May 5 2020, 2:51 AM

Change 594343 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] TestStorageHelper: Replace createEntity with createNewEntity

https://gerrit.wikimedia.org/r/594343

gerritbot added a project: Patch-For-Review.May 5 2020, 2:51 AM
gerritbot added a comment.May 11 2020, 10:33 PM

Change 594343 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] TestStorageHelper: Replace createEntity with createNewEntity

https://gerrit.wikimedia.org/r/594343

gerritbot added a comment.May 11 2020, 10:36 PM

Change 595667 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] TestStorageHelper: Replace saveJudgment with updateJudgement

https://gerrit.wikimedia.org/r/595667

gerritbot added a comment.May 11 2020, 10:53 PM

Change 595667 abandoned by DannyS712:
TestStorageHelper: Replace saveJudgment with updateJudgement

Reason:
Messed up, will redo when I have a chance

https://gerrit.wikimedia.org/r/595667

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.32; 2020-05-12); removed MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).May 11 2020, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 11 2020, 11:10 PM
DannyS712 removed DannyS712 as the assignee of this task.Jun 7 2020, 2:49 AM
DannyS712 updated the task description. (Show Details)Sep 13 2020, 7:51 PM
gerritbot added a comment.Sep 13 2020, 7:53 PM

Change 626890 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Remove TestStorageHelper::saveJudgment use of $wgUser

https://gerrit.wikimedia.org/r/626890

gerritbot added a project: Patch-For-Review.Sep 13 2020, 7:53 PM
DannyS712 added a project: Platform Team Workboards (External Code Reviews).Sep 13 2020, 7:56 PM
gerritbot added a comment.Sep 13 2020, 8:03 PM

Change 626891 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Remove TestStorageHelper::makeEdit use of $wgUser

https://gerrit.wikimedia.org/r/626891

gerritbot added a comment.Sep 13 2020, 8:15 PM

Change 626892 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Jade@master] Remove uses of $wgUser in PageEntityProposalSetStorageTest

https://gerrit.wikimedia.org/r/626892

gerritbot added a comment.Sep 14 2020, 4:46 AM

Change 626890 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Remove TestStorageHelper::saveJudgment use of $wgUser

https://gerrit.wikimedia.org/r/626890

gerritbot added a comment.Sep 14 2020, 4:49 AM

Change 626891 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Remove TestStorageHelper::makeEdit use of $wgUser

https://gerrit.wikimedia.org/r/626891

gerritbot added a comment.Sep 14 2020, 4:56 AM

Change 626892 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Remove uses of $wgUser in PageEntityProposalSetStorageTest

https://gerrit.wikimedia.org/r/626892

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.9; 2020-09-15).Sep 14 2020, 5:00 AM
DannyS712 closed this task as Resolved.Sep 14 2020, 5:29 AM
DannyS712 claimed this task.
DannyS712 removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL