Page MenuHomePhabricator
Create Task
Maniphest T241956

Remove Profiler::profileIn and ::profileOut, deprecated and unused
Closed, ResolvedPublic
Actions

Description

Neither is used, and both were deprecated in 1.33.
See codesearch: https://codesearch.wmflabs.org/search/?q=profile(In%7COut)%5C(&i=nope&files=&repos=

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
profiler: Remove deprecated profileIn/profileOutmediawiki/coremaster+5 -10
Remove Profiler::profileIn and ::profileOut, deprecated and unusedmediawiki/coremaster+1 -18
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Jan 6 2020, 12:16 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 6 2020, 12:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Untriaged to 2019 | MW 1.33 / 1.34 on the Technical-Debt (Deprecation process) board.Jan 6 2020, 12:16 AM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 updated the task description. (Show Details)Jan 6 2020, 12:23 AM
DannyS712 mentioned this in T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.
gerritbot added a comment.Feb 21 2020, 5:04 AM

Change 573847 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove Profiler::profileIn and ::profileOut, deprecated and unused

https://gerrit.wikimedia.org/r/573847

gerritbot added a project: Patch-For-Review.Feb 21 2020, 5:04 AM
DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.Feb 21 2020, 5:06 AM
Krinkle added a project: Performance-Team.Feb 21 2020, 2:56 PM
Krinkle added a project: MediaWiki-Core-Profiler.Feb 21 2020, 3:01 PM
• Gilles moved this task from Inbox, needs triage to Radar on the Performance-Team board.Feb 25 2020, 5:35 PM
• Gilles edited projects, added: Performance-Team (Radar); removed: Performance-Team.
Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Feb 28 2020, 6:36 PM
gerritbot added a comment.Mar 3 2020, 5:36 PM

Change 573847 abandoned by DannyS712:
Remove Profiler::profileIn and ::profileOut, deprecated and unused

https://gerrit.wikimedia.org/r/573847

DannyS712 removed DannyS712 as the assignee of this task.Mar 3 2020, 5:36 PM
DannyS712 removed a project: Patch-For-Review.
DannyS712 moved this task from Awaiting review and deployment to Others on the User-DannyS712 board.
DannyS712 added a subscriber: Krinkle.

Don't really understand this - leaving for someone else
@Krinkle does this still belong in "Watching"?

Krinkle added a project: patch-welcome.Mar 12 2020, 10:10 PM

Yes, our team is not currently working on it, but are subscribed to get notifications and offer code review if needed.

Jdforrester-WMF mentioned this in T259108: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.36 release.Jul 29 2020, 9:13 AM
DannyS712 removed a project: User-DannyS712.Sep 11 2020, 9:16 PM
gerritbot added a comment.Dec 18 2021, 4:39 PM

Change 748253 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] profiler: Remove deprecated profileIn/profileOut

https://gerrit.wikimedia.org/r/748253

gerritbot added a project: Patch-For-Review.Dec 18 2021, 4:39 PM
gerritbot added a comment.Jan 6 2022, 12:56 AM

Change 748253 merged by jenkins-bot:

[mediawiki/core@master] profiler: Remove deprecated profileIn/profileOut

https://gerrit.wikimedia.org/r/748253

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.17; 2022-01-10).Jan 6 2022, 1:00 AM
Krinkle closed this task as Resolved.Jan 6 2022, 1:40 PM
Krinkle assigned this task to Umherirrender.
Krinkle triaged this task as Low priority.
Krinkle edited projects, added: Performance-Team; removed: Patch-For-Review, Performance-Team (Radar).
Krinkle moved this task from Inbox, needs triage to Backlog: Maintenance, non-prioritized on the Performance-Team board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits