Page MenuHomePhabricator
Create Task
Maniphest T241957

Remove CommentStore::newKey, deprecated and unused
Closed, ResolvedPublic
Actions

Description

Deprecated in 1.31, no longer used
See codesearch: https://codesearch.wmflabs.org/search/?q=newKey%5C(&i=nope&files=&repos=

Details

SubjectRepoBranchLines +/-
Remove CommentStore::newKey, deprecated and unusedmediawiki/coremaster+11 -230
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Jan 6 2020, 12:21 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJan 6 2020, 12:21 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Untriaged to 2018 | MW 1.31 / 1.32 on the Technical-Debt (Deprecation process) board.Jan 6 2020, 12:21 AM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 updated the task description. (Show Details)
DannyS712 mentioned this in T232864: Drop legacy hard-deprecated code from MediaWiki ahead of MediaWiki 1.35 release.Jan 6 2020, 12:24 AM
gerritbot added a comment.Feb 13 2020, 5:30 AM

Change 571861 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Remove CommentStore::newKey, deprecated and unused

https://gerrit.wikimedia.org/r/571861

gerritbot added a project: Patch-For-Review.Feb 13 2020, 5:30 AM
DannyS712 moved this task from Next to Awaiting review and deployment on the User-DannyS712 board.Feb 13 2020, 5:37 AM
DannyS712 added a comment.Feb 14 2020, 3:05 AM

This also remove backwards compatibility for not providing keys to a number of functions

gerritbot added a comment.Feb 20 2020, 2:31 AM

Change 571861 merged by jenkins-bot:
[mediawiki/core@master] Remove CommentStore::newKey, deprecated and unused

https://gerrit.wikimedia.org/r/571861

DannyS712 closed this task as Resolved.Feb 20 2020, 2:40 AM
DannyS712 removed a project: Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.21; 2020-02-25).Feb 20 2020, 3:00 AM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Feb 23 2020, 10:23 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL