Page MenuHomePhabricator
Create Task
Maniphest T241972

wmgUseEntitySourceBasedFederation true for Wikidata.org
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Revert "Revert "Set useEntitySourceBasedFederation to true for Wikidata""operations/mediawiki-configmaster+1 -0
Better dependency injection of base URI in ConstraintParameterParsermediawiki/extensions/WikibaseQualityConstraintswmf/1.35.0-wmf.15+14 -22
Better dependency injection of base URI in ConstraintParameterParsermediawiki/extensions/WikibaseQualityConstraintswmf/1.35.0-wmf.16+14 -22
Better dependency injection of base URI in ConstraintParameterParsermediawiki/extensions/WikibaseQualityConstraintsmaster+14 -22
Set useEntitySourceBasedFederation to true for Wikidataoperations/mediawiki-configmaster+1 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore created this task.Jan 6 2020, 9:21 AM
Addshore moved this task from Incoming to Ready to pick up on the Wikidata-Campsite board.Jan 7 2020, 10:30 AM
Addshore moved this task from Ready to pick up to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.Jan 7 2020, 1:30 PM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 7 2020, 2:15 PM
gerritbot added a comment.Jan 7 2020, 6:54 PM

Change 562578 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/mediawiki-config@master] Set useEntitySourceBasedFederation to true for Wikidata

https://gerrit.wikimedia.org/r/562578

gerritbot added a project: Patch-For-Review.Jan 7 2020, 6:54 PM
Ladsgroup claimed this task.Jan 7 2020, 6:54 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 7 2020, 6:54 PM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.Jan 7 2020, 7:15 PM
Addshore triaged this task as High priority.Jan 14 2020, 4:09 PM
WMDE-leszek added a comment.Jan 16 2020, 12:53 PM

is this in "peer review" (whatever that means for the config change really), or is it blocked/waiting for the train rolling and any possible other circumstances to change?

WMDE-leszek closed subtask T241973: wmgUseEntitySourceBasedFederation true for test.wikidata.org as Resolved.Jan 16 2020, 12:54 PM
gerritbot added a comment.Jan 21 2020, 12:01 PM

Change 562578 merged by jenkins-bot:
[operations/mediawiki-config@master] Set useEntitySourceBasedFederation to true for Wikidata

https://gerrit.wikimedia.org/r/562578

Stashbot added a comment.Jan 21 2020, 12:07 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-21T12:07:23Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:562578|Set useEntitySourceBasedFederation to true for Wikidata (T241972)]] (duration: 01m 12s)

Maintenance_bot removed a project: Patch-For-Review.Jan 21 2020, 12:11 PM
Stashbot added a comment.Jan 21 2020, 12:12 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-21T12:12:52Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:562578|Set useEntitySourceBasedFederation to true for Wikidata (T241972)]] (duration: 00m 59s)

Stashbot added a comment.Jan 21 2020, 12:28 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-21T12:28:48Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: Revert [[gerrit:562578|Set useEntitySourceBasedFederation to true for Wikidata (T241972)]] (duration: 01m 00s)

Stashbot added a comment.Jan 21 2020, 12:29 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-21T12:29:51Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: Revert [[gerrit:562578|Set useEntitySourceBasedFederation to true for Wikidata (T241972)]] (duration: 00m 58s)

Ladsgroup added a comment.Jan 21 2020, 12:30 PM

Caused this: https://logstash.wikimedia.org/goto/ff697b3578f6d02db73c203507d0bad4

No base URI for concept URI for repository: 
t exception.trace 	
	#0 /srv/mediawiki/php-1.35.0-wmf.15/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Helper/ConstraintParameterParser.php(755): WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ConstraintParameterParser->parseUnitParameter(Wikibase\DataModel\Entity\ItemId)
#1 /srv/mediawiki/php-1.35.0-wmf.15/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Helper/ConstraintParameterParser.php(785): WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ConstraintParameterParser->parseUnitItem(WikibaseQuality\ConstraintReport\ConstraintCheck\ItemIdSnakValue)
#2 /srv/mediawiki/php-1.35.0-wmf.15/extensions/WikibaseQualityConstraints/src/ConstraintCheck/Checker/AllowedUnitsChecker.php(84): WikibaseQuality\ConstraintReport\ConstraintCheck\Helper\ConstraintParameterParser->parseUnitsParameter(array, string)
#3 /srv/mediawiki/php-1.35.0-wmf.15/extensions/WikibaseQualityConstraints/src/ConstraintCheck/DelegatingConstraintChecker.php(566): WikibaseQuality\ConstraintReport\ConstraintCheck\Checker\AllowedUnitsChecker->checkConstraint(WikibaseQuality\ConstraintReport\ConstraintCheck\Context\MainSnakContext, WikibaseQuality\ConstraintReport\Constraint)
#4 /srv/mediawiki/php-1.35.0-wmf.15/extensions/WikibaseQualityConstraints/src/ConstraintCheck/DelegatingConstraintChecker.php(460): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->getCheckResultFor(WikibaseQuality\ConstraintReport\ConstraintCheck\Context\MainSnakContext, WikibaseQuality\ConstraintReport\Constraint)
#5 /srv/mediawiki/php-1.35.0-wmf.15/extensions/WikibaseQualityConstraints/src/ConstraintCheck/DelegatingConstraintChecker.php(374): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->checkConstraintsForMainSnak(Wikibase\DataModel\Entity\Item, Wikibase\DataModel\Statement\Statement, NULL, array)
#6 /srv/mediawiki/php-1.35.0-wmf.15/extensions/WikibaseQualityConstraints/src/ConstraintCheck/DelegatingConstraintChecker.php(346): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->checkStatement(Wikibase\DataModel\Entity\Item, Wikibase\DataModel\Statement\Statement, NULL, array)
#7 /srv/mediawiki/php-1.35.0-wmf.15/extensions/WikibaseQualityConstraints/src/ConstraintCheck/DelegatingConstraintChecker.php(154): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->checkEveryStatement(Wikibase\DataModel\Entity\Item, NULL, array)
#8 /srv/mediawiki/php-1.35.0-wmf.15/extensions/WikibaseQualityConstraints/src/Api/CheckingResultsSource.php(53): WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker->checkAgainstConstraintsOnEntityId(Wikibase\DataModel\Entity\ItemId, NULL, array, array)
#9 /srv/mediawiki/php-1.35.0-wmf.15/extensions/WikibaseQualityConstraints/src/Api/CachingResultsSource.php(235): WikibaseQuality\ConstraintReport\Api\CheckingResultsSource->getResults(array, array, NULL, array)
#10 /srv/mediawiki/php-1.35.0-wmf.15/extensions/WikibaseQualityConstraints/src/Api/CachingResultsSource.php(167): WikibaseQuality\ConstraintReport\Api\CachingResultsSource->getAndStoreResults(array, array, NULL, array)
#11 /srv/mediawiki/php-1.35.0-wmf.15/extensions/WikibaseQualityConstraints/src/Api/CheckConstraints.php(172): WikibaseQuality\ConstraintReport\Api\CachingResultsSource->getResults(array, array, NULL, array)
#12 /srv/mediawiki/php-1.35.0-wmf.15/includes/api/ApiMain.php(1603): WikibaseQuality\ConstraintReport\Api\CheckConstraints->execute()
#13 /srv/mediawiki/php-1.35.0-wmf.15/includes/api/ApiMain.php(539): ApiMain->executeAction()
#14 /srv/mediawiki/php-1.35.0-wmf.15/includes/api/ApiMain.php(510): ApiMain->executeActionWithErrorHandling()
#15 /srv/mediawiki/php-1.35.0-wmf.15/api.php(78): ApiMain->execute()
#16 /srv/mediawiki/w/api.php(3): require(string)
#17 {main}
Ladsgroup moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 21 2020, 12:31 PM
gerritbot added a comment.Jan 21 2020, 2:08 PM

Change 566287 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseQualityConstraints@master] Better dependency injection of base URI in ConstraintParameterParser

https://gerrit.wikimedia.org/r/566287

gerritbot added a project: Patch-For-Review.Jan 21 2020, 2:08 PM
Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 21 2020, 2:08 PM
Michael subscribed.Jan 21 2020, 2:51 PM

This is related to the errors with the phatality id ab64e499d026f371bf3bdeb734a881ce0a881b28744605e775d113987d28702c

gerritbot added a comment.Jan 21 2020, 5:31 PM

Change 566287 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Better dependency injection of base URI in ConstraintParameterParser

https://gerrit.wikimedia.org/r/566287

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 21 2020, 6:00 PM
Ladsgroup mentioned this in rEBQCfd64c68a6b0e: Better dependency injection of base URI in ConstraintParameterParser.Jan 21 2020, 6:04 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 21 2020, 6:10 PM
Addshore moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 22 2020, 10:16 AM
gerritbot added a comment.Jan 22 2020, 11:36 AM

Change 566504 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.35.0-wmf.15] Better dependency injection of base URI in ConstraintParameterParser

https://gerrit.wikimedia.org/r/566504

gerritbot added a project: Patch-For-Review.Jan 22 2020, 11:36 AM

Change 566505 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.35.0-wmf.16] Better dependency injection of base URI in ConstraintParameterParser

https://gerrit.wikimedia.org/r/566505

gerritbot added a comment.Jan 22 2020, 11:37 AM

Change 566506 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[operations/mediawiki-config@master] Revert "Revert "Set useEntitySourceBasedFederation to true for Wikidata""

https://gerrit.wikimedia.org/r/566506

Addshore edited parent tasks, added: T243395: wmgUseEntitySourceBasedFederation true for Wikimedia clients (all sites); removed: T241971: useEntitySourceBasedFederation true by default in Wikibase.Jan 22 2020, 12:12 PM
gerritbot added a comment.Jan 22 2020, 12:33 PM

Change 566505 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.35.0-wmf.16] Better dependency injection of base URI in ConstraintParameterParser

https://gerrit.wikimedia.org/r/566505

Ladsgroup mentioned this in rEBQC9a2401f8858c: Better dependency injection of base URI in ConstraintParameterParser.Jan 22 2020, 12:34 PM
Stashbot added a comment.Jan 22 2020, 12:36 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-22T12:36:56Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.16/extensions/WikibaseQualityConstraints: [[gerrit:566505|Better dependency injection of base URI in ConstraintParameterParser (T241972)]] (duration: 01m 14s)

gerritbot added a comment.Jan 22 2020, 12:40 PM

Change 566504 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@wmf/1.35.0-wmf.15] Better dependency injection of base URI in ConstraintParameterParser

https://gerrit.wikimedia.org/r/566504

Ladsgroup mentioned this in rEBQC26adbb4c0670: Better dependency injection of base URI in ConstraintParameterParser.Jan 22 2020, 12:41 PM
gerritbot added a comment.Jan 22 2020, 12:44 PM

Change 566506 merged by jenkins-bot:
[operations/mediawiki-config@master] Revert "Revert "Set useEntitySourceBasedFederation to true for Wikidata""

https://gerrit.wikimedia.org/r/566506

Stashbot added a comment.Jan 22 2020, 12:46 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-22T12:46:17Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.15/extensions/WikibaseQualityConstraints: [[gerrit:566504|Better dependency injection of base URI in ConstraintParameterParser (T241972)]] (duration: 01m 05s)

Stashbot added a comment.Jan 22 2020, 12:50 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-22T12:50:08Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:562578|Set useEntitySourceBasedFederation to true for Wikidata (T241972)]] (duration: 01m 06s)

Ladsgroup moved this task from Doing to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 22 2020, 12:51 PM
Stashbot added a comment.Jan 22 2020, 12:51 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-22T12:51:55Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:562578|Set useEntitySourceBasedFederation to true for Wikidata (T241972)]] (duration: 01m 05s)

Ladsgroup added a comment.Jan 22 2020, 12:58 PM

Caused this:

#0 /srv/mediawiki/php-1.35.0-wmf.15/extensions/Wikibase/repo/includes/Rdf/RdfVocabulary.php(419): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.35.0-wmf.15/extensions/Wikibase/repo/includes/Rdf/FullStatementRdfBuilder.php(157): Wikibase\Rdf\RdfVocabulary->getEntityRepositoryName(Wikibase\Lexeme\Domain\Model\SenseId)
#2 /srv/mediawiki/php-1.35.0-wmf.15/extensions/Wikibase/repo/includes/Rdf/FullStatementRdfBuilder.php(126): Wikibase\Rdf\FullStatementRdfBuilder->addStatement(Wikibase\Lexeme\Domain\Model\SenseId, Wikibase\DataModel\Statement\Statement, boolean)
#3 /srv/mediawiki/php-1.35.0-wmf.15/extensions/Wikibase/repo/includes/Rdf/FullStatementRdfBuilder.php(258): Wikibase\Rdf\FullStatementRdfBuilder->addStatements(Wikibase\Lexeme\Domain\Model\SenseId, Wikibase\DataModel\Statement\StatementList)
#4 /srv/mediawiki/php-1.35.0-wmf.15/extensions/Wikibase/repo/includes/Rdf/RdfBuilder.php(430): Wikibase\Rdf\FullStatementRdfBuilder->addEntity(Wikibase\Lexeme\Domain\Model\Sense)
#5 /srv/mediawiki/php-1.35.0-wmf.15/extensions/Wikibase/repo/includes/Rdf/RdfBuilder.php(441): Wikibase\Rdf\RdfBuilder->addSingleEntity(Wikibase\Lexeme\Domain\Model\Sense)
#6 /srv/mediawiki/php-1.35.0-wmf.15/extensions/Wikibase/repo/includes/Rdf/RdfBuilder.php(412): Wikibase\Rdf\RdfBuilder->addQueuedEntities()
#7 /srv/mediawiki/php-1.35.0-wmf.15/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(236): Wikibase\Rdf\RdfBuilder->addEntity(Wikibase\Lexeme\Domain\Model\Lexeme)
#8 /srv/mediawiki/php-1.35.0-wmf.15/extensions/Wikibase/repo/includes/LinkedData/EntityDataSerializationService.php(182): Wikibase\Repo\LinkedData\EntityDataSerializationService->rdfSerialize(Wikibase\Lib\Store\EntityRevision, NULL, array, Wikibase\Rdf\RdfBuilder, string)
#9 /srv/mediawiki/php-1.35.0-wmf.15/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(522): Wikibase\Repo\LinkedData\EntityDataSerializationService->getSerializedData(string, Wikibase\Lib\Store\EntityRevision, NULL, array, string)
#10 /srv/mediawiki/php-1.35.0-wmf.15/extensions/Wikibase/repo/includes/LinkedData/EntityDataRequestHandler.php(268): Wikibase\Repo\LinkedData\EntityDataRequestHandler->showData(WebRequest, OutputPage, string, Wikibase\Lexeme\Domain\Model\LexemeId, integer)
#11 /srv/mediawiki/php-1.35.0-wmf.15/extensions/Wikibase/repo/includes/Specials/SpecialEntityData.php(156): Wikibase\Repo\LinkedData\EntityDataRequestHandler->handleRequest(string, WebRequest, OutputPage)
#12 /srv/mediawiki/php-1.35.0-wmf.15/includes/specialpage/SpecialPage.php(575): Wikibase\Repo\Specials\SpecialEntityData->execute(string)
#13 /srv/mediawiki/php-1.35.0-wmf.15/includes/specialpage/SpecialPageFactory.php(611): SpecialPage->run(string)
#14 /srv/mediawiki/php-1.35.0-wmf.15/includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#15 /srv/mediawiki/php-1.35.0-wmf.15/includes/MediaWiki.php(967): MediaWiki->performRequest()
#16 /srv/mediawiki/php-1.35.0-wmf.15/includes/MediaWiki.php(530): MediaWiki->main()
#17 /srv/mediawiki/php-1.35.0-wmf.15/index.php(46): MediaWiki->run()
#18 /srv/mediawiki/w/index.php(3): require(string)
#19 {main}
ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.16; 2020-01-21); removed MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 22 2020, 1:00 PM
Ladsgroup added a comment.Jan 22 2020, 1:02 PM

For further work: https://logstash.wikimedia.org/goto/8a58e20ad11e952ebd98fec0e64da18d

Stashbot added a comment.Jan 22 2020, 1:02 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-22T13:02:22Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: Revert: [[gerrit:562578|Set useEntitySourceBasedFederation to true for Wikidata (T241972)]] (duration: 01m 05s)

Ladsgroup moved this task from Test (Verification) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 22 2020, 1:03 PM
Stashbot added a comment.Jan 22 2020, 1:03 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-22T13:03:42Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: Revert: [[gerrit:562578|Set useEntitySourceBasedFederation to true for Wikidata (T241972)]] (duration: 01m 05s)

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2020, 1:10 PM
Addshore mentioned this in T243415: Multiple repo/includes/Rdf errors, when wmgUseEntitySourceBasedFederation true on Wikidata.org.Jan 22 2020, 2:20 PM
Addshore moved this task from Doing to Stalled/Waiting on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Span the new error out into a subticket for now to be worked on

Stashbot added a comment.Jan 23 2020, 12:14 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-23T12:14:01Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:566701|Set useEntitySourceBasedFederation to true for Wikidata (T241972)]] (duration: 01m 06s)

Stashbot added a comment.Jan 23 2020, 12:15 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-23T12:15:20Z] <ladsgroup@deploy1001> Synchronized wmf-config/InitialiseSettings.php: SWAT: [[gerrit:566701|Set useEntitySourceBasedFederation to true for Wikidata (T241972)]] (duration: 01m 04s)

Ladsgroup moved this task from Stalled/Waiting to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 23 2020, 4:17 PM
Addshore closed subtask T243415: Multiple repo/includes/Rdf errors, when wmgUseEntitySourceBasedFederation true on Wikidata.org as Resolved.Jan 23 2020, 7:38 PM
Addshore closed this task as Resolved.Jan 24 2020, 10:19 AM
Maintenance_bot moved this task from In progress to Done on the User-Ladsgroup board.Jan 24 2020, 11:15 AM
Bugreporter mentioned this in T244529: mw.wikibase.getLabelByLang not return item label for some items, because MIGRATION_WRITE_NEW is being deployed with train for wmf.18.Feb 7 2020, 7:38 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL