Page MenuHomePhabricator
Create Task
Maniphest T241980

A translatable page should not be considered as broken when last change in history is a log entry
Closed, ResolvedPublicBUG REPORT
Actions

Description

When a translatable page has been moved or protected,

  • the text “This page has changes since it was last marked for translation.” is not displayed in top of the page
  • the page is listed under Broken pages section of Special:PageTranslation

… until the page is edited (or marked again for translation).

Previous title: Special:PageTranslation lists "broken pages", but they are not broken

Steps to Reproduce:
For example, see
https://www.mediawiki.org/wiki/Special:PageTranslation

Actual Results:
Special:PageTranslation shows a lot of "Broken pages".

Help:New filters for edit review/FAQ (remove from translation)
Help:Notifications/Types (remove from translation)
Help:Protected pages (remove from translation)
Help:Subpages (remove from translation)
Help:Sysops and permissions (remove from translation)
Help:User rights and groups (remove from translation)
Help:Watchlist (remove from translation)
:

Expected Results:
These pages seems not to be broken.

Outcome

Certain page actions like changing the protection levels no longer cause translatable page's status to be "broken".

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Translatemaster+78 -13Copy selected revtags for a new revisions with unchanged content
Customize query in gerrit

Event Timeline

Shirayuki created this task.Jan 6 2020, 11:34 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2020, 11:34 AM
Nikerabbit added a subscriber: Nikerabbit.Jan 10 2020, 12:37 PM

I checked three pages, two had a protection log entry as last change in history (a bug I believe) and one didn't have <translate> tags so broken from the point of the system: https://www.mediawiki.org/w/index.php?title=Manual:Glossary

Pols12 added a subscriber: Pols12.Feb 6 2020, 2:51 PM

I am fixing these pages on Meta:

  • for pages with no <translate> tag, often, an editor wanted to remove the possibility to translate. So translation administrator should just use “remove from translation” action link from Special:PageTranslation.
  • for pages which have been protected since they have been marked for translation, to workaround this bug, translation administrator should mark the page again for translation, using the following link: https://meta.wikimedia.org/w/index.php?title=Special:PageTranslation&target=<Issued_page_name>&do=mark.
Pols12 added a comment.EditedFeb 6 2020, 4:28 PM

Another case:

The last history changes in history are an automatic move log entry (through translatable page moving system).

So this bug may concern all log entries related as last history change, and not only protections.

Shirayuki added a comment.Apr 22 2020, 10:16 PM

As described above, the following pages have a move log entry as last change.

Pols12 renamed this task from Special:PageTranslation lists "broken pages", but they are not broken to A translatable page should not be considered as broken when last change in history is a log entry.Apr 23 2020, 10:37 PM
Pols12 updated the task description. (Show Details)
Nikerabbit triaged this task as Low priority.Apr 27 2020, 8:14 AM
Nikerabbit moved this task from Backlog to page translation on the MediaWiki-extensions-Translate board.
Nikerabbit raised the priority of this task from Low to Medium.Apr 27 2020, 8:53 AM
gerritbot added a comment.Mar 11 2021, 2:20 PM

Change 670826 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/Translate@master] Move copy selected revtags to the new revision on move

https://gerrit.wikimedia.org/r/670826

gerritbot added a project: Patch-For-Review.Mar 11 2021, 2:20 PM
Nikerabbit claimed this task.Jul 14 2021, 10:53 AM
Nikerabbit added a project: Language-Team (Language-2021-July-September).
Nikerabbit moved this task from Quarter Backlog to In Review on the Language-Team (Language-2021-July-September) board.
Nikerabbit added a comment.Jul 14 2021, 11:09 AM

The code to prevent this has been in place since 2012. But it may be that other issues with translatable page moving has caused these issues. My patch touches this code too, but it should not result in a change in behavior.

gerritbot added a comment.Jul 19 2021, 5:24 PM

Change 670826 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Copy selected revtags for a new revisions with unchanged content

https://gerrit.wikimedia.org/r/670826

Maintenance_bot removed a project: Patch-For-Review.Jul 19 2021, 6:10 PM
Nikerabbit moved this task from In Review to Recheck after deployment on the Language-Team (Language-2021-July-September) board.Jul 20 2021, 2:11 PM
Nikerabbit moved this task from Recheck after deployment to Done on the Language-Team (Language-2021-July-September) board.Jul 21 2021, 2:35 PM

the page is listed under Broken pages section of Special:PageTranslation

This is fixed.

the text “This page has changes since it was last marked for translation.” is not displayed in top of the page

This is not fixed. I am not sure it is safe to suppress this. I'd recommend filing it as a separate task if it feels important.

Nikerabbit closed this task as Resolved.Jul 27 2021, 1:23 PM
Nikerabbit updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL