Maniphest T241999

Invalid yaml in horizon hiera editor results in confusing error message
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Ottomata
	Jan 6 2020, 5:03 PM

Description

While attempting to edit hiera yaml via the Horizon interface, I had an invalid extra space in my yaml. The error message given to me by Horizon when saving the form was:

Danger: There was an error submitting the form. Please try again.
11:51:27 and no hiera is saved

Which made me assume there was a bug with Horizon. It'd be nice to have some kind of useful 'invalid yaml syntax' error insteed.

Details

	Subject	Repo	Branch	Lines +/-
	Show a better error message on YAML parse failure	openstack/horizon/wmf-puppet-dashboard	main	+20 -1

Customize query in gerrit

Related Objects

Duplicates Merged Here: T199555: HTTP 500 from edithiera endpoint when given certain hiera data

Event Timeline

Ottomata created this task.Jan 6 2020, 5:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2020, 5:03 PM

bd808 edited projects, added Horizon, Puppet; removed Cloud-Services.Jan 6 2020, 5:04 PM

bd808 moved this task from Backlog to Local dashboards on the Horizon board.Jan 6 2020, 5:11 PM

bd808 merged a task: T199555: HTTP 500 from edithiera endpoint when given certain hiera data.Jan 6 2020, 5:27 PM

bd808 added subscribers: Krenair, Andrew.

Aklapper added a project: Infrastructure-Foundations.Jun 21 2021, 8:59 PM

Change 766110 had a related patch set uploaded (by Majavah; author: Majavah):

[openstack/horizon/wmf-puppet-dashboard@main] Show a better error message on YAML parse failure

https://gerrit.wikimedia.org/r/766110

gerritbot added a project: Patch-For-Review.Feb 25 2022, 2:46 PM

The PS above updates the error to look like this:

Change 766110 merged by Majavah: