Page MenuHomePhabricator

[Bug] Icon spacing discrepency in article header for logged-in users with AMC disabled
Open, MediumPublicBUG REPORT

Assigned To
None
Authored By
ovasileva
Jan 6 2020, 5:48 PM
Referenced Files
F31502611: Screen Shot 2020-01-06 at 10.04.44 AM.png
Jan 6 2020, 6:46 PM
F31502608: Screen Shot 2020-01-06 at 10.04.15 AM.png
Jan 6 2020, 6:46 PM
F31502614: Screen Shot 2020-01-06 at 10.05.44 AM.png
Jan 6 2020, 6:46 PM
F31502616: Screen Shot 2020-01-06 at 10.06.12 AM.png
Jan 6 2020, 6:46 PM
F31502606: Screen Shot 2020-01-06 at 10.03.36 AM.png
Jan 6 2020, 6:46 PM
F31502619: Screen Shot 2020-01-06 at 10.06.36 AM.png
Jan 6 2020, 6:46 PM
F30300359: image.png
Jan 6 2020, 5:48 PM
F31502536: image.png
Jan 6 2020, 5:48 PM

Description

Steps to reproduce

  1. Go to any mobile page as a logged-in users on iOS (or any non-Chrome browser), Firefox or Chrome with JS disabled

Expected results

image.png (669×377 px, 156 KB)

Actual results

image.png (1×750 px, 195 KB)

Notes: based on T232652#5778375, T201954: Add the print button to mobile browsers other than Chrome is a potential fix

Event Timeline

ovasileva triaged this task as Medium priority.Jan 6 2020, 5:48 PM
ovasileva created this task.
ovasileva renamed this task from [Bug] Example title to [Bug] Icon spacing wrong in article header for logged-in users.Jan 6 2020, 5:48 PM
Jdlrobson renamed this task from [Bug] Icon spacing wrong in article header for logged-in users to [Bug] Icon spacing discrepency in article header for logged-in users with AMC disabled.Jan 6 2020, 6:00 PM
Jdlrobson updated the task description. (Show Details)

Repeating what I said in https://phabricator.wikimedia.org/T232652#5778375 if we can I would encourage us moving away from maintaining 2 different versions of page actions (one with download and one without). Although this task would reduce the list of 5 that we currently maintain to 4, in an ideal world the download icon would always be present and we wouldn't have to treat them differently/. Implementing T201954 instead or push the overflow menu to all users would achieve this goal.

The 5 UIs for page actions we currently maintain:

  1. Firefox logged out (3 icons with float right)

Screen Shot 2020-01-06 at 10.03.36 AM.png (604×1 px, 73 KB)

Note: Would not be maintained if we implemented T201954

  1. firefox logged in (4 icons spaced) -

Screen Shot 2020-01-06 at 10.04.15 AM.png (1×736 px, 106 KB)

Note: this task says it should behave like #3

  1. Chrome logged out (4 icons with float)

Screen Shot 2020-01-06 at 10.04.44 AM.png (994×1 px, 123 KB)

  1. chrome logged in (5 icons spaced)

Screen Shot 2020-01-06 at 10.05.44 AM.png (994×1 px, 150 KB)

  1. chrome amc + firefox amc are the same (5 icons spaced):
Screen Shot 2020-01-06 at 10.06.12 AM.png (876×996 px, 127 KB)
Screen Shot 2020-01-06 at 10.06.36 AM.png (1×676 px, 109 KB)
ovasileva added a subscriber: alexhollender_WMF.

discussed with @alexhollender and this does not require an immediate fix. That said, I am curious what our current blockers on T201954: Add the print button to mobile browsers other than Chrome are - will comment there as well