Page MenuHomePhabricator
Create Task
Maniphest T242031

Allow multiple different 2FA devices
Open, Needs TriagePublic
Actions

Assigned To
taavi
Authored By
Reedy
Jan 6 2020, 9:47 PM
Tags
Referenced Files
None
Subscribers
Ahm_masum
Aklapper
AntiCompositeNumber
jeblad
Ladsgroup
larissagaulia
Legoktm
View All 18 Subscribers
Tokens
"Love" token, awarded by TheresNoTime."Like" token, awarded by waldyrious.

Description

Creating as an umbrella for T232336: Separate recovery codes into a separate MFA method and T230042: Allow multiple totp devices

It should be possible to have TOTP and WebAuthn enabled

[21:28:13] <AntiComposite> I know it was just deployed, but is there a reason that OATHAuth only supports TOTP _or_ WebAuthn (U2F)?
[21:29:40] <AntiComposite> Every other service I use that supports WebAuthn supports both at the same time, which means I can use my hardware key on my laptop but fall back to my TOTP generator for my phone, where WebAuthn isn't supported in the browser.

db migration progress

checkuserwiki + techconductwiki DONE
remaining private wikis DONE
fishbowls DONE
wikitech DONE
ca wikis

  • WRITE_BOTH | READ_OLD
  • run script
  • WRITE_BOTH | READ_NEW
  • WRITE_NEW | READ_NEW

Details

Other Assignee
pmiazga
SubjectRepoBranchLines +/-
Make Key objects aware of their database IDsmediawiki/extensions/OATHAuthmaster+75 -21
WebAuthnKey: Store the key idmediawiki/extensions/WebAuthnmaster+23 -1
Make the TOTP disable form only remove that single keymediawiki/extensions/OATHAuthmaster+76 -18
Database-level support for multiple auth devicesmediawiki/extensions/OATHAuthmaster+575 -131
Replace more users of getModule() for enabled checksmediawiki/extensions/OATHAuthmaster+5 -11
ApiQueryOATH: do not use module to check enablementmediawiki/extensions/OATHAuthmaster+18 -7
Do not use Module when disabling OAuth for a usermediawiki/extensions/OATHAuthmaster+10 -6
Drop support for old device schemamediawiki/extensions/OATHAuthmaster+50 -128
Set WRITE_NEW for CA wikis on OATHAuth multiple devicesoperations/mediawiki-configmaster+1 -1
Set READ_NEW for CA wikis on OATHAuth multiple devicesoperations/mediawiki-configmaster+1 -1
Set WRITE_BOTH for CA wikis on OATHAuth multiple devicesoperations/mediawiki-configmaster+1 -1
Set WRITE_NEW for Wikitech on OATHAuth multiple devices migrationoperations/mediawiki-configmaster+1 -1
Set WRITE_NEW for OATHAuth multiple devices on fishbowls/privatesoperations/mediawiki-configmaster+2 -2
Set READ_NEW for Wikitech on OATHAuth multiple devices migrationoperations/mediawiki-configmaster+1 -1
Set OATHAuth multiple devices WRITE_BOTH for wikitechoperations/mediawiki-configmaster+1 -0
Set OATHAuth multiple devices READ_NEW for all fishbows, privatesoperations/mediawiki-configmaster+2 -4
Set OATHAuth multiple devices READ_NEW for checkuser, techconductoperations/mediawiki-configmaster+2 -2
Set OATHAuth multiple devices WRITE_BOTH for all privatesoperations/mediawiki-configmaster+1 -0
Set OATHAuth multiple devices WRITE_BOTH for all fishbowlsoperations/mediawiki-configmaster+1 -0
Set WRITE_BOTH for OAuth multiple devices to checkuserwikioperations/mediawiki-configmaster+1 -0
Set WRITE_BOTH for OAuth multiple devices to techconductwikioperations/mediawiki-configmaster+1 -0
Keep both tables up-to-date on WRITE_BOTHmediawiki/extensions/OATHAuthmaster+17 -22
Keep both tables up-to-date on WRITE_BOTHmediawiki/extensions/OATHAuthwmf/1.41.0-wmf.20+17 -22
Keep both tables up-to-date on WRITE_BOTHmediawiki/extensions/OATHAuthwmf/1.41.0-wmf.22+17 -22
OAuthUserRepository: Ensure we don't end up with duplicate rowsmediawiki/extensions/OATHAuthwmf/1.41.0-wmf.22+13 -3
OAuthUserRepository: Ensure we don't end up with duplicate rowsmediawiki/extensions/OATHAuthwmf/1.41.0-wmf.20+13 -3
OAuthUserRepository: Ensure we don't end up with duplicate rowsmediawiki/extensions/OATHAuthmaster+13 -3
[beta] Read new for OATHAuthMultipleDevicesMigrationStageoperations/mediawiki-configmaster+1 -1
[beta] Write both for OATHAuthMultipleDevicesMigrationStageoperations/mediawiki-configmaster+3 -0
Set OATHAuthMultipleDevicesMigrationStage to MIGRATION_OLDoperations/mediawiki-configmaster+2 -0
API: Do not expose the module name in the outputmediawiki/extensions/OATHAuthmaster+0 -2
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes
gerritbot added a comment.Aug 16 2023, 3:28 AM

Change 949168 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@wmf/1.41.0-wmf.20] Keep both tables up-to-date on WRITE_BOTH

https://gerrit.wikimedia.org/r/949168

Stashbot added a comment.Aug 16 2023, 3:29 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-16T03:29:27Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:949169|Keep both tables up-to-date on WRITE_BOTH (T242031)]], [[gerrit:949168|Keep both tables up-to-date on WRITE_BOTH (T242031)]]

Stashbot added a comment.Aug 16 2023, 3:31 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-16T03:31:04Z] <taavi@deploy1002> taavi: Backport for [[gerrit:949169|Keep both tables up-to-date on WRITE_BOTH (T242031)]], [[gerrit:949168|Keep both tables up-to-date on WRITE_BOTH (T242031)]] synced to the testservers mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

gerritbot added a comment.Aug 16 2023, 3:31 AM

Change 949188 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Keep both tables up-to-date on WRITE_BOTH

https://gerrit.wikimedia.org/r/949188

Stashbot added a comment.Aug 16 2023, 3:40 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-16T03:40:26Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:949169|Keep both tables up-to-date on WRITE_BOTH (T242031)]], [[gerrit:949168|Keep both tables up-to-date on WRITE_BOTH (T242031)]] (duration: 10m 58s)

gerritbot added a comment.Aug 16 2023, 3:43 AM

Change 949161 merged by jenkins-bot:

[operations/mediawiki-config@master] Set WRITE_BOTH for OAuth multiple devices to techconductwiki

https://gerrit.wikimedia.org/r/949161

Stashbot added a comment.Aug 16 2023, 3:44 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-16T03:44:25Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:949161|Set WRITE_BOTH for OAuth multiple devices to techconductwiki (T242031)]]

Stashbot added a comment.Aug 16 2023, 3:45 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-16T03:45:58Z] <taavi@deploy1002> taavi: Backport for [[gerrit:949161|Set WRITE_BOTH for OAuth multiple devices to techconductwiki (T242031)]] synced to the testservers mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Stashbot added a comment.Aug 16 2023, 3:53 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-16T03:53:32Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:949161|Set WRITE_BOTH for OAuth multiple devices to techconductwiki (T242031)]] (duration: 09m 07s)

Maintenance_bot removed a project: Patch-For-Review.Aug 16 2023, 4:10 AM
Stashbot added a comment.Aug 16 2023, 8:03 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-16T08:03:53Z] <taavi> mwscript extensions/OATHAuth/maintenance/UpdateForMultipleDevicesSupport.php techconductwiki # T242031

SQL removed a subscriber: SQL.Aug 16 2023, 9:17 AM
gerritbot added a comment.Aug 17 2023, 7:19 AM

Change 949629 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/mediawiki-config@master] Set WRITE_BOTH for OAuth multiple devices to checkuserwiki

https://gerrit.wikimedia.org/r/949629

gerritbot added a project: Patch-For-Review.Aug 17 2023, 7:19 AM
gerritbot added a comment.Aug 18 2023, 1:34 AM

Change 949629 merged by jenkins-bot:

[operations/mediawiki-config@master] Set WRITE_BOTH for OAuth multiple devices to checkuserwiki

https://gerrit.wikimedia.org/r/949629

Stashbot added a comment.Aug 18 2023, 1:34 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-18T01:34:32Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:949629|Set WRITE_BOTH for OAuth multiple devices to checkuserwiki (T242031)]]

Stashbot added a comment.Aug 18 2023, 1:36 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-18T01:36:13Z] <taavi@deploy1002> taavi: Backport for [[gerrit:949629|Set WRITE_BOTH for OAuth multiple devices to checkuserwiki (T242031)]] synced to the testservers mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Stashbot added a comment.Aug 18 2023, 1:42 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-18T01:42:21Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:949629|Set WRITE_BOTH for OAuth multiple devices to checkuserwiki (T242031)]] (duration: 07m 48s)

Maintenance_bot removed a project: Patch-For-Review.Aug 18 2023, 2:10 AM
TheresNoTime awarded a token.Aug 18 2023, 8:40 AM
Stashbot added a comment.Aug 21 2023, 7:29 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-21T19:29:08Z] <taavi> run extensions/OATHAuth/maintenance/UpdateForMultipleDevicesSupport.php on checkuserwiki, T242031

taavi added a comment.Aug 21 2023, 7:30 PM

for checkuserwiki:
{P50690}

gerritbot added a comment.Aug 22 2023, 6:44 AM

Change 951367 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/mediawiki-config@master] Set OATHAuth multiple devices WRITE_BOTH for all fishbowls

https://gerrit.wikimedia.org/r/951367

gerritbot added a project: Patch-For-Review.Aug 22 2023, 6:44 AM
gerritbot added a comment.Aug 24 2023, 8:25 AM

Change 951367 merged by jenkins-bot:

[operations/mediawiki-config@master] Set OATHAuth multiple devices WRITE_BOTH for all fishbowls

https://gerrit.wikimedia.org/r/951367

Stashbot added a comment.Aug 24 2023, 8:25 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-24T08:25:31Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:951367|Set OATHAuth multiple devices WRITE_BOTH for all fishbowls (T242031)]]

Stashbot added a comment.Aug 24 2023, 8:27 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-24T08:27:05Z] <taavi@deploy1002> taavi: Backport for [[gerrit:951367|Set OATHAuth multiple devices WRITE_BOTH for all fishbowls (T242031)]] synced to the testservers mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Maintenance_bot removed a project: Patch-For-Review.Aug 24 2023, 8:30 AM
Stashbot added a comment.Aug 24 2023, 8:33 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-24T08:33:16Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:951367|Set OATHAuth multiple devices WRITE_BOTH for all fishbowls (T242031)]] (duration: 07m 45s)

Stashbot added a comment.Aug 24 2023, 11:31 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-24T11:31:35Z] <taavi> foreachwikiindblist fishbowl extensions/OATHAuth/maintenance/UpdateForMultipleDevicesSupport.php | tee oathauth-multiple-fishbowl.log # T242031

gerritbot added a comment.Aug 24 2023, 11:35 AM

Change 952184 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/mediawiki-config@master] Set OATHAuth multiple devices WRITE_BOTH for all privates

https://gerrit.wikimedia.org/r/952184

gerritbot added a project: Patch-For-Review.Aug 24 2023, 11:35 AM

Change 952185 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/mediawiki-config@master] Set OATHAuth multiple devices READ_NEW for checkuser, techconduct

https://gerrit.wikimedia.org/r/952185

gerritbot added a comment.Aug 28 2023, 5:31 PM

Change 952184 merged by jenkins-bot:

[operations/mediawiki-config@master] Set OATHAuth multiple devices WRITE_BOTH for all privates

https://gerrit.wikimedia.org/r/952184

gerritbot added a comment.Aug 28 2023, 5:31 PM

Change 952185 merged by jenkins-bot:

[operations/mediawiki-config@master] Set OATHAuth multiple devices READ_NEW for checkuser, techconduct

https://gerrit.wikimedia.org/r/952185

Stashbot added a comment.Aug 28 2023, 5:32 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-28T17:32:10Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:952184|Set OATHAuth multiple devices WRITE_BOTH for all privates (T242031)]], [[gerrit:952185|Set OATHAuth multiple devices READ_NEW for checkuser, techconduct (T242031)]]

Stashbot added a comment.Aug 28 2023, 5:33 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-28T17:33:42Z] <taavi@deploy1002> taavi: Backport for [[gerrit:952184|Set OATHAuth multiple devices WRITE_BOTH for all privates (T242031)]], [[gerrit:952185|Set OATHAuth multiple devices READ_NEW for checkuser, techconduct (T242031)]] synced to the testservers mwdebug1001.eqiad.wmnet, mwdebug2001.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2002.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD opti

Stashbot added a comment.Aug 28 2023, 5:39 PM

Mentioned in SAL (#wikimedia-operations) [2023-08-28T17:39:51Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:952184|Set OATHAuth multiple devices WRITE_BOTH for all privates (T242031)]], [[gerrit:952185|Set OATHAuth multiple devices READ_NEW for checkuser, techconduct (T242031)]] (duration: 07m 41s)

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Aug 29 2023, 5:10 PM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.25; 2023-09-05); removed MW-1.41-notes (1.41.0-wmf.20; 2023-08-01).Aug 29 2023, 6:10 PM
Stashbot added a comment.Sep 7 2023, 9:14 AM

Mentioned in SAL (#wikimedia-operations) [2023-09-07T09:14:47Z] <taavi> foreachwikiindblist private extensions/OATHAuth/maintenance/UpdateForMultipleDevicesSupport.php | tee oathauth-multiple-private.log # T242031

gerritbot added a comment.Sep 7 2023, 9:19 AM

Change 955671 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/mediawiki-config@master] Set OATHAuth multiple devices WRITE_BOTH for wikitech

https://gerrit.wikimedia.org/r/955671

gerritbot added a comment.Sep 7 2023, 9:22 AM

Change 955670 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/mediawiki-config@master] Set OATHAuth multiple devices READ_NEW for all fishbows, privates

https://gerrit.wikimedia.org/r/955670

gerritbot added a comment.Sep 7 2023, 1:28 PM

Change 955670 merged by jenkins-bot:

[operations/mediawiki-config@master] Set OATHAuth multiple devices READ_NEW for all fishbows, privates

https://gerrit.wikimedia.org/r/955670

gerritbot added a comment.Sep 7 2023, 1:28 PM

Change 955671 merged by jenkins-bot:

[operations/mediawiki-config@master] Set OATHAuth multiple devices WRITE_BOTH for wikitech

https://gerrit.wikimedia.org/r/955671

Stashbot added a comment.Sep 7 2023, 1:29 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-07T13:29:12Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:955670|Set OATHAuth multiple devices READ_NEW for all fishbows, privates (T242031)]], [[gerrit:955671|Set OATHAuth multiple devices WRITE_BOTH for wikitech (T242031)]]

Stashbot added a comment.Sep 7 2023, 1:30 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-07T13:30:41Z] <taavi@deploy1002> taavi: Backport for [[gerrit:955670|Set OATHAuth multiple devices READ_NEW for all fishbows, privates (T242031)]], [[gerrit:955671|Set OATHAuth multiple devices WRITE_BOTH for wikitech (T242031)]] synced to the testservers mwdebug2001.codfw.wmnet, mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Stashbot added a comment.Sep 7 2023, 1:38 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-07T13:38:04Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:955670|Set OATHAuth multiple devices READ_NEW for all fishbows, privates (T242031)]], [[gerrit:955671|Set OATHAuth multiple devices WRITE_BOTH for wikitech (T242031)]] (duration: 08m 52s)

Stashbot added a comment.Sep 7 2023, 1:38 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-07T13:38:55Z] <taavi> taavi@mwmaint1002 ~ $ mwscript extensions/OATHAuth/maintenance/UpdateForMultipleDevicesSupport.php --wiki=labswiki | tee oathauth-multiple-labswiki.log # T242031

gerritbot added a comment.Sep 19 2023, 7:37 PM

Change 959042 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/mediawiki-config@master] Set READ_NEW for Wikitech on OATHAuth multiple devices migration

https://gerrit.wikimedia.org/r/959042

gerritbot added a comment.Sep 19 2023, 7:37 PM

Change 959043 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/mediawiki-config@master] Set WRITE_NEW for OATHAuth multiple devices on fishbowls/privates

https://gerrit.wikimedia.org/r/959043

gerritbot added a comment.Sep 20 2023, 7:03 AM

Change 959042 merged by jenkins-bot:

[operations/mediawiki-config@master] Set READ_NEW for Wikitech on OATHAuth multiple devices migration

https://gerrit.wikimedia.org/r/959042

gerritbot added a comment.Sep 20 2023, 7:03 AM

Change 959043 merged by jenkins-bot:

[operations/mediawiki-config@master] Set WRITE_NEW for OATHAuth multiple devices on fishbowls/privates

https://gerrit.wikimedia.org/r/959043

Stashbot added a comment.Sep 20 2023, 7:05 AM

Mentioned in SAL (#wikimedia-operations) [2023-09-20T07:05:06Z] <taavi@deploy2002> Started scap: Backport for [[gerrit:959042|Set READ_NEW for Wikitech on OATHAuth multiple devices migration (T242031)]], [[gerrit:959043|Set WRITE_NEW for OATHAuth multiple devices on fishbowls/privates (T242031)]]

Stashbot added a comment.Sep 20 2023, 7:26 AM

Mentioned in SAL (#wikimedia-operations) [2023-09-20T07:26:54Z] <taavi@deploy2002> taavi: Backport for [[gerrit:959042|Set READ_NEW for Wikitech on OATHAuth multiple devices migration (T242031)]], [[gerrit:959043|Set WRITE_NEW for OATHAuth multiple devices on fishbowls/privates (T242031)]] synced to the testservers mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental X

Stashbot added a comment.Sep 20 2023, 7:41 AM

Mentioned in SAL (#wikimedia-operations) [2023-09-20T07:41:16Z] <taavi@deploy2002> Finished scap: Backport for [[gerrit:959042|Set READ_NEW for Wikitech on OATHAuth multiple devices migration (T242031)]], [[gerrit:959043|Set WRITE_NEW for OATHAuth multiple devices on fishbowls/privates (T242031)]] (duration: 36m 09s)

gerritbot added a comment.Sep 26 2023, 8:37 PM

Change 961236 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/mediawiki-config@master] Set WRITE_NEW for Wikitech on OATHAuth multiple devices migration

https://gerrit.wikimedia.org/r/961236

gerritbot added a comment.Sep 26 2023, 8:37 PM

Change 961237 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/mediawiki-config@master] Set WRITE_BOTH for CA wikis on OATHAuth multiple devices

https://gerrit.wikimedia.org/r/961237

gerritbot added a comment.Sep 26 2023, 8:40 PM

Change 961236 merged by jenkins-bot:

[operations/mediawiki-config@master] Set WRITE_NEW for Wikitech on OATHAuth multiple devices migration

https://gerrit.wikimedia.org/r/961236

Stashbot added a comment.Sep 26 2023, 8:40 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-26T20:40:50Z] <taavi@deploy2002> Started scap: Backport for [[gerrit:961236|Set WRITE_NEW for Wikitech on OATHAuth multiple devices migration (T242031)]]

Stashbot added a comment.Sep 26 2023, 8:42 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-26T20:42:19Z] <taavi@deploy2002> taavi: Backport for [[gerrit:961236|Set WRITE_NEW for Wikitech on OATHAuth multiple devices migration (T242031)]] synced to the testservers mwdebug1001.eqiad.wmnet, mwdebug2002.codfw.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

Stashbot added a comment.Sep 26 2023, 8:48 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-26T20:48:29Z] <taavi@deploy2002> Finished scap: Backport for [[gerrit:961236|Set WRITE_NEW for Wikitech on OATHAuth multiple devices migration (T242031)]] (duration: 07m 38s)

gerritbot added a comment.Sep 28 2023, 1:45 PM

Change 961237 merged by jenkins-bot:

[operations/mediawiki-config@master] Set WRITE_BOTH for CA wikis on OATHAuth multiple devices

https://gerrit.wikimedia.org/r/961237

Stashbot added a comment.Sep 28 2023, 1:45 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-28T13:45:58Z] <taavi@deploy2002> Started scap: Backport for [[gerrit:961237|Set WRITE_BOTH for CA wikis on OATHAuth multiple devices (T242031)]]

Stashbot added a comment.Sep 28 2023, 1:47 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-28T13:47:19Z] <taavi@deploy2002> taavi: Backport for [[gerrit:961237|Set WRITE_BOTH for CA wikis on OATHAuth multiple devices (T242031)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Sep 28 2023, 1:57 PM

Mentioned in SAL (#wikimedia-operations) [2023-09-28T13:57:28Z] <taavi@deploy2002> Finished scap: Backport for [[gerrit:961237|Set WRITE_BOTH for CA wikis on OATHAuth multiple devices (T242031)]] (duration: 11m 02s)

Maintenance_bot removed a project: Patch-For-Review.Sep 28 2023, 2:12 PM
Stashbot added a comment.Oct 4 2023, 4:49 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-04T16:49:18Z] <taavi> taavi@mwmaint2002 ~ $ mwscript extensions/OATHAuth/maintenance/UpdateForMultipleDevicesSupport.php metawiki | tee T242031-sul.log # T242031

gerritbot added a comment.Oct 4 2023, 5:37 PM

Change 963388 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/mediawiki-config@master] Set READ_NEW for CA wikis on OATHAuth multiple devices

https://gerrit.wikimedia.org/r/963388

gerritbot added a project: Patch-For-Review.Oct 4 2023, 5:37 PM
gerritbot added a comment.Oct 10 2023, 8:39 PM

Change 963388 merged by jenkins-bot:

[operations/mediawiki-config@master] Set READ_NEW for CA wikis on OATHAuth multiple devices

https://gerrit.wikimedia.org/r/963388

Stashbot added a comment.Oct 10 2023, 8:40 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-10T20:40:16Z] <taavi@deploy2002> Started scap: Backport for [[gerrit:963388|Set READ_NEW for CA wikis on OATHAuth multiple devices (T242031)]]

Stashbot added a comment.Oct 10 2023, 8:41 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-10T20:41:40Z] <taavi@deploy2002> taavi: Backport for [[gerrit:963388|Set READ_NEW for CA wikis on OATHAuth multiple devices (T242031)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Stashbot added a comment.Oct 10 2023, 8:48 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-10T20:48:41Z] <taavi@deploy2002> Finished scap: Backport for [[gerrit:963388|Set READ_NEW for CA wikis on OATHAuth multiple devices (T242031)]] (duration: 08m 24s)

taavi updated the task description. (Show Details)Oct 10 2023, 9:08 PM
Maintenance_bot removed a project: Patch-For-Review.Oct 10 2023, 9:10 PM
gerritbot added a comment.Oct 10 2023, 9:51 PM

Change 964986 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/OATHAuth@master] Drop support for old device schema

https://gerrit.wikimedia.org/r/964986

gerritbot added a project: Patch-For-Review.Oct 10 2023, 9:51 PM

Change 964987 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/OATHAuth@master] Make Key objects aware of their database IDs

https://gerrit.wikimedia.org/r/964987

gerritbot added a comment.Oct 10 2023, 9:51 PM

Change 964988 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/OATHAuth@master] Make the TOTP disable form only remove that single key

https://gerrit.wikimedia.org/r/964988

gerritbot added a comment.Oct 10 2023, 9:51 PM

Change 964989 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/OATHAuth@master] Do not use Module when disabling OAuth for a user

https://gerrit.wikimedia.org/r/964989

gerritbot added a comment.Oct 10 2023, 10:35 PM

Change 964996 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/WebAuthn@master] WebAuthnKey: Store the key id

https://gerrit.wikimedia.org/r/964996

gerritbot added a comment.Oct 11 2023, 8:54 PM

Change 965250 had a related patch set uploaded (by Majavah; author: Majavah):

[operations/mediawiki-config@master] Set WRITE_NEW for CA wikis on OATHAuth multiple devices

https://gerrit.wikimedia.org/r/965250

gerritbot added a comment.Oct 11 2023, 8:55 PM

Change 965250 merged by jenkins-bot:

[operations/mediawiki-config@master] Set WRITE_NEW for CA wikis on OATHAuth multiple devices

https://gerrit.wikimedia.org/r/965250

Stashbot added a comment.Oct 11 2023, 8:55 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-11T20:55:53Z] <taavi@deploy2002> Started scap: Backport for [[gerrit:965250|Set WRITE_NEW for CA wikis on OATHAuth multiple devices (T242031)]]

Stashbot added a comment.Oct 11 2023, 8:57 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-11T20:57:13Z] <taavi@deploy2002> taavi: Backport for [[gerrit:965250|Set WRITE_NEW for CA wikis on OATHAuth multiple devices (T242031)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

taavi updated the task description. (Show Details)Oct 11 2023, 9:04 PM
Stashbot added a comment.Oct 11 2023, 9:06 PM

Mentioned in SAL (#wikimedia-operations) [2023-10-11T21:06:27Z] <taavi@deploy2002> Finished scap: Backport for [[gerrit:965250|Set WRITE_NEW for CA wikis on OATHAuth multiple devices (T242031)]] (duration: 10m 33s)

gerritbot added a comment.Oct 17 2023, 6:07 PM

Change 964986 merged by jenkins-bot:

[mediawiki/extensions/OATHAuth@master] Drop support for old device schema

https://gerrit.wikimedia.org/r/964986

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 17 2023, 7:00 PM
gerritbot added a comment.Thu, Nov 23, 7:00 PM

Change 977109 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/OATHAuth@master] Replace more users of getModule() for enabled checks

https://gerrit.wikimedia.org/r/977109

gerritbot added a comment.Thu, Nov 23, 7:00 PM

Change 977110 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/OATHAuth@master] ApiQueryOATH: do not use module to check enablement

https://gerrit.wikimedia.org/r/977110

taavi added a project: MediaWiki-Platform-Team.Fri, Nov 24, 12:15 PM

Hi, the patches starting from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/OATHAuth/+/964987 could use some reviews :-)

larissagaulia moved this task from Inbox, needs triage to Current Sprint on the MediaWiki-Platform-Team board.Mon, Nov 27, 4:08 PM
larissagaulia updated Other Assignee, added: pmiazga.
larissagaulia added a subscriber: larissagaulia.

Thanks, Taavi. Piotr volunteered to take a look at the open patches. Please feel free to reach out to him :)

Marostegui closed subtask T348693: Drop oathauth_users table from production as Resolved.Wed, Nov 29, 8:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL