Page MenuHomePhabricator

Toolbar : Indent button should indent each line
Closed, ResolvedPublic

Description

Author: wikibugs

Description:
Wiki_r61227_2010-01-21_OperaIndent.pdf

Reporting against Babaco Release : r61227

Steps to Reproduce ::

  1. Add some bullets to the editor
  2. Select two bullets and click on ident

<<The last bullet selected get in to the first line>>

Expected Outcome::

Both selected bullets should indented correctly

Test Environment::

Opera/9.63 (Windows NT 6.0; U; en) Presto/2.1.1
Opera/9.80 (Windows NT 5.1; U; en) Presto/2.2.15 Version/10.00


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz22209

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.
StatusSubtypeAssignedTask
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:52 PM
bzimport set Reference to bz22209.

Changing to enhancement - this is something we should probably do to improve our list tools as well.

Adam did this in r61493; would be nice to have for list tools too (I suggested this as well in a CR comment) but that's a one-line change for every button, so I'm closing this bug.

wikibugs wrote:

Verified in r61537
The bug still there is in Opera

Opera/9.63 (Windows NT 6.0; U; en) Presto/2.1.1

Opera/9.80 (X11; Linux i686; U; en) Presto/2.2.15 Version /10.00

(In reply to comment #4)

Verified in r61537
The bug still there is in Opera

Opera/9.63 (Windows NT 6.0; U; en) Presto/2.1.1

Opera/9.80 (X11; Linux i686; U; en) Presto/2.2.15 Version /10.00

I fixed related code in r61576, could you try again?

wikibugs wrote:

verified in r61584

The problem still exits.

  • Bug 22574 has been marked as a duplicate of this bug. ***

Looks like it got reverted. It's not in jquery.textselection

(In reply to comment #8)

Looks like it got reverted. It's not in jquery.textselection

It seems the code got lost somehow, yes. Adam introduced the splitlines option in r61493, but it somehow didn't make it into the core version of jquery.textSelection . However, the part of r61493 that changed the toolbar config to pass 'splitlines':true for the indent button did survive somehow.

Reintroduced splitlines support in r86622, multi-line indent works now. Tested in FF4 and IE8.