Page MenuHomePhabricator

Spike: WWT: WhoColor API does not work with some tokens
Open, Needs TriagePublicBUG REPORT

Description

As a WWT user, I want characters not handled by WhoColor to receive support in WWT (if possible), so that I can access information on more content.

Background: Some words are not highlighted and have no revision popup in WWT. This is because they contain characters the WhoColor API does not support. This is a known issue in the WhoColor code. I raised here. From this comment in the WhoColor code:

# token is not found. because most probably it contains some characters that has different length
# in lower and upper case such as 'İstanbul'

So far, I have only found this affecting the character İ (LATIN CAPITAL LETTER I WITH DOT ABOVE). However, this appears frequently in Turkish Wikipedia. From a random sample of 1000 articles on trwiki I found this character in about 700 of them. (Some of the appearances are in templates, so have no user-facing affect.) This includes the article https://tr.wikipedia.org/wiki/%C4%B0stanbul (which is unfortunate).

Acceptance Criteria:

  • Investigate if there is any way we can support or fix this issue
  • Implement a fix, if possible

Steps to reproduce problem:

  1. Go to https://tr.wikipedia.org/wiki/%C4%B0stanbul
  2. Turn on WWT
  3. Hover over and/or attempt to click on the first word "İstanbul"

Expected behavior: "İstanbul" is highlighted and a revision popup appears when clicked
Observed behavior: Nothing happens

Visual Example (inability to click on 'Istanbul'):

Screen Shot 2020-01-21 at 1.26.03 PM.png (521×1 px, 382 KB)

Event Timeline

ifried renamed this task from WWT: WhoColor API does not work with some tokens to Spike: WWT: WhoColor API does not work with some tokens.Jan 21 2020, 10:44 PM

This is a weird bug, but I don't think it's a problem of the character, I think there might be an issue in WhoColor with this specific article?

Look at other instances of İstanbul on the page -- these are tokenized. Example:

İstanbul - Vikipedi.png (235×413 px, 47 KB)

I think we should look into potentially other causes here? Maybe a specific issue within WhoColor on the first word?

I've also checked, and this doesn't seem to appear in many other places in the page (see screenshot below). For this reason, this may be something we want to contact WikiWho about, but this may be much less common than originally anticipated.

Screen Shot 2020-01-21 at 5.50.27 PM.png (251×486 px, 47 KB)