Page MenuHomePhabricator
Create Task
Maniphest T242092

Disabled RadioSelectWidget is still selectable by click in Firefox
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:

  1. With a Firefox Browser go to https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop#RadioSelectWidget and go to the RadioSelectWidget section
  2. click the grey circle in front of "Goldfish"

Actual Results:
The item is selected and a previously selected radio-button is deselected

image.png (58×130 px, 3 KB)

Expected Results:
The item is not interactable and clicking the circle does nothing (like in chrome)

image.png (102×130 px, 4 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+535 -464Update OOUI to v0.36.4
oojs/uimaster+5 -0SelectWidget: Check if we can highlight/select items on focus before we do it
Customize query in gerrit

Event Timeline

Michael created this task.Jan 7 2020, 11:16 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 7 2020, 11:17 AM
Volker_E triaged this task as High priority.Jan 31 2020, 10:05 PM
Volker_E added a subscriber: matmarex.
matmarex claimed this task.Jan 31 2020, 10:35 PM

Oh yeah I was going to have a look at this.

gerritbot added a comment.Jan 31 2020, 10:45 PM

Change 569288 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[oojs/ui@master] SelectWidget: Check if we can highlight/select items on focus before we do it

https://gerrit.wikimedia.org/r/569288

gerritbot added a project: Patch-For-Review.Jan 31 2020, 10:45 PM
gerritbot added a comment.Feb 1 2020, 12:18 AM

Change 569288 merged by jenkins-bot:
[oojs/ui@master] SelectWidget: Check if we can highlight/select items on focus before we do it

https://gerrit.wikimedia.org/r/569288

Maintenance_bot removed a project: Patch-For-Review.Feb 1 2020, 1:10 AM
Volker_E moved this task from Backlog to Waiting for breaking release on the OOUI board.Feb 1 2020, 2:19 AM
Volker_E moved this task from Waiting for breaking release to OOUI-0.36.4 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.36.4); removed OOUI.
Volker_E closed this task as Resolved.Feb 3 2020, 11:14 PM
gerritbot added a comment.Feb 5 2020, 7:51 PM

Change 570418 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.36.4

https://gerrit.wikimedia.org/r/570418

gerritbot added a project: Patch-For-Review.Feb 5 2020, 7:51 PM
gerritbot added a comment.Feb 5 2020, 9:10 PM

Change 570418 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.36.4

https://gerrit.wikimedia.org/r/570418

Maintenance_bot removed a project: Patch-For-Review.Feb 5 2020, 9:11 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL