Page MenuHomePhabricator

TermSearchInteractor should have a new implementation supporting new terms storage
Closed, ResolvedPublic

Description

Highlighted in T232040#5774510

Event Timeline

Change 562320 had a related patch set uploaded (by Addshore; owner: Sarhan):
[mediawiki/extensions/Wikibase@master] Update SingleEntitySourceServices to respect item terms migration stages

https://gerrit.wikimedia.org/r/562320

Maybe I'm wrong here but the lack of implementation for TermSearchInteractor is not related to SingleEntitySourceServices. An entity source based federation would also need an implementation of it as well.

Change 563396 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Move search parts of LegacyEntityTermStoreReader into MatchingTermsLookup

https://gerrit.wikimedia.org/r/563396

Change 563419 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/ArticlePlaceholder@master] Use the new name of TermIndexSearchInteractor

https://gerrit.wikimedia.org/r/563419

Change 563420 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Remove class alias for TermIndexSearchInteractor

https://gerrit.wikimedia.org/r/563420

Change 563421 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Rename TermIndexSearchInteractorFactory to MatchingTermsSearchInteractorFactory

https://gerrit.wikimedia.org/r/563421

Change 563998 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Use MatchingTermsLookup instead of TermIndex in TermIndexPropertyLabelResolver

https://gerrit.wikimedia.org/r/563998

Change 563396 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move search parts of LegacyEntityTermStoreReader into MatchingTermsLookup

https://gerrit.wikimedia.org/r/563396

Change 563419 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] Use the new name of TermIndexSearchInteractor

https://gerrit.wikimedia.org/r/563419

Change 563420 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Remove class alias for TermIndexSearchInteractor

https://gerrit.wikimedia.org/r/563420

Change 563421 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Rename TermIndexSearchInteractorFactory to MatchingTermsSearchInteractorFactory

https://gerrit.wikimedia.org/r/563421

Change 564013 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/ArticlePlaceholder@master] Use MockMatchingTermsLookup instead of MockTermIndex

https://gerrit.wikimedia.org/r/564013

Change 564013 abandoned by Ladsgroup:
Use MockMatchingTermsLookup instead of MockTermIndex

Reason:
Doesn't work :/

https://gerrit.wikimedia.org/r/564013

Change 563998 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use MatchingTermsLookup instead of TermIndex in TermIndexPropertyLabelResolver

https://gerrit.wikimedia.org/r/563998

Maybe I'm wrong here but the lack of implementation for TermSearchInteractor is not related to SingleEntitySourceServices. An entity source based federation would also need an implementation of it as well.

Correct!

Change 564772 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] [WIP] Start DatabaseMatchingTermsLookup

https://gerrit.wikimedia.org/r/564772

Ladsgroup renamed this task from SingleEntitySourceServices TermSearchInteractor should use new terms storage to TermSearchInteractor should have a implementation supporting new terms storage.Jan 15 2020, 8:11 AM
Ladsgroup renamed this task from TermSearchInteractor should have a implementation supporting new terms storage to TermSearchInteractor should have a new implementation supporting new terms storage.

Change 564772 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Start DatabaseMatchingTermsLookup

https://gerrit.wikimedia.org/r/564772