Page MenuHomePhabricator
Create Task
Maniphest T242117

Test that icon shows only when taintedState is true and editState is false
Closed, ResolvedPublic
Actions

Related Objects
Search...

Event Timeline

Rosalie_WMDE created this task.Jan 7 2020, 3:16 PM
Rosalie_WMDE moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint8 board.Jan 8 2020, 4:28 PM
Rosalie_WMDE moved this task from Doing to To Do on the Wikidata-Tainted-References-Sprint8 board.Jan 9 2020, 10:18 AM
hoo claimed this task.Jan 10 2020, 2:17 PM
hoo moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint8 board.
Tarrow removed hoo as the assignee of this task.Jan 14 2020, 10:51 AM
Tarrow moved this task from Doing to To Do on the Wikidata-Tainted-References-Sprint8 board.
Tarrow added subscribers: hoo, Tarrow.

We heard in the daily that @hoo is of the office for a couple of days apparently so I stuck this back in todo

Rosalie_WMDE claimed this task.Jan 15 2020, 9:31 AM
Rosalie_WMDE moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint8 board.
Rosalie_WMDE added a comment.Jan 15 2020, 11:33 AM

It seems this patch already resolves this ticket: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/564008
I will put the ticket in review. If anyone confirms, then we may close the ticket.

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint8 board.Jan 15 2020, 11:34 AM
Tarrow closed this task as Resolved.Jan 16 2020, 9:56 AM
Tarrow moved this task from Peer Review to Done on the Wikidata-Tainted-References-Sprint8 board.

Indeed, I think this is done :)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL