StopEditing Hook should dispatch STOP_EDIT action
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Rosalie_WMDE
	Jan 7 2020, 3:20 PM

Details

Subject	Repo	Branch	Lines +/-
TR: Don't dispatch STOP_EDIT action on save	mediawiki/extensions/Wikibase	master	+92 -78
CancelHook handler should not set tainted state to untaint	mediawiki/extensions/Wikibase	master	+1 -2
Add a cancel hook handler and set store states	mediawiki/extensions/Wikibase	master	+46 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Lydia_Pintscher	T234790 Step 2: show tainted icon after canceling editing if icon was shown before
		Resolved		Tarrow	T242119 StopEditing Hook should dispatch STOP_EDIT action

Event Timeline

Rosalie_WMDE created this task.Jan 7 2020, 3:20 PM

Rosalie_WMDE removed Rosalie_WMDE as the assignee of this task.Jan 7 2020, 3:24 PM

hoo renamed this task from Change cancel hook to set taintState to false if taintState is true and editState is false to Cancel hook handler should set taintState to false if taintState is true and editState is false.Jan 8 2020, 11:53 PM

Rosalie_WMDE claimed this task.Jan 16 2020, 12:21 PM

Rosalie_WMDE moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint8 board.

Rosalie_WMDE renamed this task from Cancel hook handler should set taintState to false if taintState is true and editState is false to Cancel hook handler should set taintState to false.Jan 16 2020, 12:36 PM

Change 565270 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] Add a cancel hook handler and set store states

https://gerrit.wikimedia.org/r/565270

gerritbot added a project: Patch-For-Review.Jan 16 2020, 1:34 PM

Addshore moved this task from incoming to in progress on the Wikidata board.Jan 16 2020, 7:40 PM

hoo claimed this task.Jan 17 2020, 10:56 AM

hoo moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint8 board.Jan 17 2020, 5:41 PM

I was looking through this task. As far as I can tell to achieve what we need for the story we do not want to have the stopEditingHook set the TaintedState to false.

Indeed, the story is about keeping a statement tainted after cancelling.

I think we should actually only change the editingState on the stopEditing hook.

I therefore suggest we change the task title from "Cancel hook handler should set taintState to false" to "StopEditing Hook should dispatch STOP_EDIT action"

@hoo and @Rosalie_WMDE can you double check if I've made some mistake?

@Tarrow You are right, canceling an edit should not set the taintState to false, it should rather set it to the value before edit.
My bad, I created this task

Rosalie_WMDE renamed this task from Cancel hook handler should set taintState to false to StopEditing Hook should dispatch STOP_EDIT action.Jan 20 2020, 10:17 AM

Rosalie_WMDE moved this task from Peer Review to Doing on the Wikidata-Tainted-References-Sprint8 board.

WMDE-leszek added a project: Wikidata-Tainted-References-Sprint9.Jan 20 2020, 10:37 AM

WMDE-leszek moved this task from To Do to Doing on the Wikidata-Tainted-References-Sprint9 board.

The patch up now doesn't change the visible behaviour, as it still explicitly untaints the statement once the edit is cancelled. Changing that behavior (so that the statement will be shown as tainted still) is just a matter of deleting a line now, though.

hoo moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint9 board.Jan 20 2020, 11:48 AM

Change 565270 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Add a cancel hook handler and set store states

https://gerrit.wikimedia.org/r/565270

Maintenance_bot removed a project: Patch-For-Review.Jan 20 2020, 1:10 PM

Rosalie_WMDE moved this task from Peer Review to Doing on the Wikidata-Tainted-References-Sprint9 board.Jan 20 2020, 3:31 PM

Change 566058 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] CancelHook handler should not set tainted state to untaint

https://gerrit.wikimedia.org/r/566058

gerritbot added a project: Patch-For-Review.Jan 20 2020, 3:38 PM

Rosalie_WMDE moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint9 board.Jan 20 2020, 3:38 PM

Tarrow claimed this task.Jan 22 2020, 10:35 AM

Tarrow moved this task from Peer Review to Doing on the Wikidata-Tainted-References-Sprint9 board.

Tarrow added a subscriber: hoo.

Change 566058 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] CancelHook handler should not set tainted state to untaint

https://gerrit.wikimedia.org/r/566058

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2020, 11:10 AM

Change 566717 had a related patch set uploaded (by Tarrow; owner: Tarrow):
[mediawiki/extensions/Wikibase@master] TR: Don't dispatch STOP_EDIT action on save

https://gerrit.wikimedia.org/r/566717

gerritbot added a project: Patch-For-Review.Jan 23 2020, 12:38 PM

Tarrow moved this task from Doing to Peer Review on the Wikidata-Tainted-References-Sprint9 board.Jan 23 2020, 12:44 PM

Rosalie_WMDE moved this task from Peer Review to Done on the Wikidata-Tainted-References-Sprint9 board.Jan 27 2020, 4:37 PM

Change 566717 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] TR: Don't dispatch STOP_EDIT action on save

https://gerrit.wikimedia.org/r/566717

Maintenance_bot removed a project: Patch-For-Review.Jan 27 2020, 5:10 PM

Lydia_Pintscher closed this task as Resolved.Jan 29 2020, 10:40 AM