EchoEvent::create should allow returning a status object
Closed, DuplicatePublic
Actions

Assigned To

None

Authored By

	DannyS712
	Jan 7 2020, 7:23 PM

Description

Currently, EchoEvent::create returns EchoEvent|false False if aborted via hook or Echo DB is read-only. It should also be able to return a status object to explain why the echo event was aborted via hook

Use case:
T235873: Add variables in Abusefilter to detect/block thanks - there should be a way to pass AbuseFilter warnings/disallow messages to the thanks api when the AbuseFilter aborts the insertion of an event

Related Objects

Mentioned Here: T169834: Change EchoEvent->create to return Status or throw exceptions, never false
T235873: Add variables in Abusefilter to detect/block thanks

Event Timeline

DannyS712 created this task.Jan 7 2020, 7:23 PM

DannyS712 moved this task from Unsorted to Others on the User-DannyS712 board.

T169834: Change EchoEvent->create to return Status or throw exceptions, never false seems duplicate and even has a pending patch.

In T242153#5789029, @matej_suchanek wrote:

T169834: Change EchoEvent->create to return Status or throw exceptions, never false seems duplicate and even has a pending patch.

Didn't see that

DannyS712 closed this task as a duplicate of T169834: Change EchoEvent->create to return Status or throw exceptions, never false.Jan 9 2020, 6:14 PM

DannyS712 removed a parent task: T241474: Thank api assumes that echo event will go through.

matej_suchanek removed a subscriber: matej_suchanek.Jan 10 2020, 6:53 PM

DannyS712 moved this task from Others to Archive on the User-DannyS712 board.Jan 13 2020, 1:03 AM

EchoEvent::create should allow returning a status objectClosed, DuplicatePublicActions

Description

Related Objects

Event Timeline

EchoEvent::create should allow returning a status object
Closed, DuplicatePublic
Actions