Page MenuHomePhabricator

mobile-html: optimize accessibility
Open, MediumPublic

Description

Parent ticket: T226401#5780144

09) The Edit link is not labeled.

image.png (154×1 px, 64 KB)

The edit pencil should have a correct label for the accessibility tool on a mobile device to say "Edit $title section"

(13) When using the Black theme, the color contrast between links and the background is 3.2:1. It should be at least 4.5:1. This was the only color contrast issue observed with the theme settings. Can we use colorAccent (color_group_3) for the links in dark and black mode?

image.png (678×864 px, 185 KB)

The color hex should be #69f#C8CCD1 (See comments from design).

(15) The superscript link on articles is 13dp x 14dp. Please increase to 48dp.

This comment might be helpful: https://phabricator.wikimedia.org/T226401#5348504

(16) The edit link within articles is 25dp x 26dp. Please increase to 48dp.

Add margin or padding on the edit pencil should be enough.

Event Timeline

Jhernandez raised the priority of this task from Low to Medium.Jan 8 2020, 4:44 PM

Can Design please sign off that this change is ok for both platforms in terms of color before we get to it?

Thanks!

@Jhernandez would it be possible to use #C8CCD1 for the edit pencil instead? This has a contrast ratio of 13.01 against black and more closely matches the relationship between the text / blue link / edit pencil on default. @schoenbaechler would this work for you?

@cmadeo

@Jhernandez would it be possible to use #C8CCD1 for the edit pencil instead? This has a contrast ratio of 13.01 against black and more closely matches the relationship between the text / blue link / edit pencil on default. @schoenbaechler would this work for you?

Works for me!

Hey @LGoto - can we re-up this on the PI radar? Would be good to have these accessibility tweaks taken care of. Not burning down the house urgent, but nice to have from an accessibility point of view.

Change 592771 had a related patch set uploaded (by BearND; owner: BearND):
[mediawiki/services/mobileapps@master] mobile-html: change link color

https://gerrit.wikimedia.org/r/592771

Created subtasks for the individual items in the task description.

bearND subscribed.