Steps to reproduce:
Visit https://phabricator.wikimedia.org/tag/deprecated-security-team-reviews/ (I got there from looking through T241451: Security Review For SpamRegex extension
Expected result:
Explanation that the tag doesn't exist or something
Actual result:
Unhandled Exception ("Exception")
You must use withSourcePHIDs() to query edges.Suspect that this is Phabricator (Upstream), but not tagging in case there is a configuration issue that caused it (not very familiar with phabricator software)
This may be caused by @Chase's work for T242032: make security-team-reviews a subproject of security-team-services.
Interesting that https://phabricator.wikimedia.org/project/profile/944/ can be reached.
Looked a bit at the DB but I cannot spot any pattern, as only some tasks associated with deprecated-security-team-reviews are affected.
No problem: SELECT t.id,e.* FROM edge e JOIN maniphest_task t WHERE (t.id = 88171 OR t.id = 163827 OR t.id = 239259) AND (e.src = t.phid) AND e.dst LIKE "%PHID-PROJ%" ORDER BY t.id,e.dst,e.dateCreated;
Problem: SELECT t.id,e.* FROM edge e JOIN maniphest_task t WHERE (t.id = 216419 OR t.id = 211489 OR t.id = 217289 OR t.id = 69536 OR t.id = 159709) AND (e.src = t.phid) AND e.dst ORDER BY t.id,e.dst,e.dateCreated;
SELECT * FROM phabricator_project.project_transaction pt WHERE pt.objectPHID = "PHID-PROJ-dyuzopdkrb3qbyuzhhkm" AND dateModified > 1578400000; also looks alright to me. It shows that the slugs security-reviews and security-team-reviews were removed. Both are now slugs of Application Security Reviews.
If noone finds time to dig deeper, I'd propose to silently mass-remove the deprecated-security-team-reviews tag and mass-add Application Security Reviews for all (closed) items listed in https://phabricator.wikimedia.org/maniphest/query/c2Wrcgq95SiK/#R .