Page MenuHomePhabricator

Reword 'I accept' button to 'Submit' on Terms of Use page
Closed, ResolvedPublic

Description

Task

It's confusing to users that the form on the Terms of Use page (https://wikipedialibrary.wmflabs.org/terms/) has both a check box and an "I Accept" button. Users expect that the button is sufficient to accept, without the check box. Additionally, users can un-accept the terms, to do which they need to un-check the box and then click... "I Accept".

We should re-word the button to 'Submit' so that it's more obvious the check box should be selected first.

To fix this:

Good first bug

This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.

If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.

If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!

How to contribute

Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!

To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted. Experienced contributors to the project will review your code and either provide feedback or merge it in!

Event Timeline

I'm not sure if it's too small of a task for GCI, but if not then sure!

Yes - I wanted to pull the changes to review them but didn't find time last week. @AVasanth_WMF could you review? It's a fairly straightforward code change, but from a quick review it wasn't clear to me if the contributor might have inadvertently changed the css class for the button too.

Is this issue solved? I am new to open source, and I am looking for a good first task.

@Poojayadav12 hi! please see some previous comments! This task is almost ready to be closed, you can take a look at other tasks in the good first task list.

Open pull request has stalled, so this task is open again.

Hey @Lutrome - any luck making progress on this? Anything you need help with?

Saloniig added a subscriber: Saloniig.

Hi, I am new to open source and want to contribute in this project. Can you please guide me about it.
Thanks

@Samwalton9 Sorry about the delay, things have been crazy thanks to the pandemic but I should have this done by the end of the week.

Submitted PR: https://github.com/WikipediaLibrary/TWLight/pull/476

I admit, I am super confused about how to make VS Code, when it's remoted to the container, see both the TWLIght project and the Python modules used by the virtual environment Docker creates.
But at least I was able to test the changes successfully.

Thanks for filing the PR! I left a quick comment about one aspect of your changes.

I admit, I am super confused about how to make VS Code, when it's remoted to the container, see both the TWLIght project and the Python modules used by the virtual environment Docker creates.

Ah yes, we wrote a guide at https://github.com/WikipediaLibrary/TWLight/wiki/PyCharm-setup on how to configure this correctly for PyCharm. I'm not familiar with the process for VS Code, but this guide might be helpful?