Page MenuHomePhabricator
Create Task
Maniphest T242211

PropertySuggester should not use TermIndex
Closed, ResolvedPublic
Actions

Description

TermSqlindex uses the old wb_terms table that is slowly being removed (see T208425)
Thus PropertySuggester should not use it.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use TermBuffer instead of TermIndexmediawiki/extensions/PropertySuggestermaster+40 -74
Customize query in gerrit

Related Objects

Event Timeline

Addshore created this task.Jan 8 2020, 11:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 8 2020, 11:12 AM
Addshore added a project: Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)).Jan 8 2020, 11:13 AM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 8 2020, 11:15 AM
WMDE-leszek subscribed.Jan 8 2020, 11:18 AM
Addshore mentioned this in T208425: [EPIC] Kill the wb_terms table.Jan 8 2020, 11:21 AM
Jakob_WMDE claimed this task.Jan 8 2020, 11:59 AM
Jakob_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jan 8 2020, 4:54 PM

Change 562871 had a related patch set uploaded (by Jakob; owner: Jakob):
[mediawiki/extensions/PropertySuggester@master] Use TermBuffer instead of TermIndex

https://gerrit.wikimedia.org/r/562871

gerritbot added a project: Patch-For-Review.Jan 8 2020, 4:54 PM
Ladsgroup awarded a token.Jan 8 2020, 5:09 PM
Jakob_WMDE moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 9 2020, 4:46 PM
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 10 2020, 6:34 AM
gerritbot added a comment.Jan 10 2020, 7:08 AM

Change 562871 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Use TermBuffer instead of TermIndex

https://gerrit.wikimedia.org/r/562871

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2020, 7:10 AM
Jakob_WMDE mentioned this in rEPSd5e6bccd1647: Use TermBuffer instead of TermIndex.Jan 10 2020, 7:10 AM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 10 2020, 8:00 AM
Addshore closed this task as Resolved.Jan 15 2020, 5:08 PM
Addshore mentioned this in T243530: PropertySuggester does not show labels from fallback languages.Jan 24 2020, 7:44 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits