MediaInfoIdLookup::getEntityIds should omit entities it can't find
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	matthiasmullie
	Jan 8 2020, 1:28 PM

Description

Current implementation might return an array with null values, but that's in violation with the interface's documentation, which states that "Implementations may omit non-existing entities from the result. If they are included, they should have negative array keys."

Details

	Subject	Repo	Branch	Lines +/-
	Omit entities that could not be found	mediawiki/extensions/WikibaseMediaInfo	master	+1 -1

Customize query in gerrit

Event Timeline

matthiasmullie created this task.Jan 8 2020, 1:28 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 8 2020, 1:28 PM

matthiasmullie moved this task from Incoming to Code Review on the Structured-Data-Backlog (Current Work) board.Jan 8 2020, 1:28 PM

Change 563105 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/WikibaseMediaInfo@master] Omit entities that could not be found

https://gerrit.wikimedia.org/r/563105

gerritbot added a project: Patch-For-Review.Jan 9 2020, 7:33 AM

Change 563105 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Omit entities that could not be found

https://gerrit.wikimedia.org/r/563105

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 9 2020, 12:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 9 2020, 12:10 PM

matthiasmullie closed this task as Resolved.Jan 13 2020, 6:57 PM

MediaInfoIdLookup::getEntityIds should omit entities it can't findClosed, ResolvedPublicActions

Description

Details

Event Timeline

MediaInfoIdLookup::getEntityIds should omit entities it can't find
Closed, ResolvedPublic
Actions