| hueitan | |
| Jan 9 2020, 4:59 PM |
| F31507887: 08 - Search results - no results.png | |
| Jan 10 2020, 10:38 PM |
| F31507889: 13 - No connection search results.png | |
| Jan 10 2020, 10:38 PM |
| F31507892: 08a - change search language - no search results found.png | |
| Jan 10 2020, 10:38 PM |
Both search and article change page use ListView component, and currently show the empty state when there is no item.
Article change language page : T234628#5789845
We need a design for when there are no search or language results.
| No search results found | No internet connection on search | No language search results |
|---|---|---|
 |  |  |
| https://zpl.io/a7xnpgE | https://zpl.io/Vxv4kQw | https://zpl.io/bzRGxOG |
Note that the article API output contains languagecount to indicate in how many other languages the article is available. When this is 0, we could hide or disable the article language menu option so we don't have to deal with an empty state on that screen.
I think we still need the No result found page in article language page
Here's one exception I found
go to the article en/Fessale, go to the second page and choose Hodh Ech Chargui, the languagecount is given 27, but when you go to the article language page, it returns 0 langlinks.
but if you go to the page Hodh Ech Chargui Region, and it's article language page, then we will have those 27 langlinks.
I have tried on mobile web page, when we load https://en.m.wikipedia.org/wiki/Hodh_Ech_Chargui, it will redirect to https://en.m.wikipedia.org/wiki/Hodh_Ech_Chargui_Region, so the above problem won't be existed, maybe we can do the same here. will try and see
To summarize this task, we need to show the empty state (No results found message) when searching the item in the following pages
Noted that the proposed design for the No Internet Connection is being handled in other task
waiting for a fix for this case
the PR for this issue is https://github.com/wikimedia/wikipedia-kaios/pull/81
the fix won't come for this task
https://github.com/wikimedia/wikipedia-kaios/pull/81#issuecomment-574680864
will be fixed here https://phabricator.wikimedia.org/T242553
@SBisson
Since we have this problem only after the article preview, we use the new summary API, the api returns titles.canonical, in this case Hodh_Ech_Chargui_Region, we can use this to load the article page without worrying about the redirection.
Edit: Fix pr can be seen here https://github.com/wikimedia/wikipedia-kaios/pull/97