Page MenuHomePhabricator

Create common http subobject for re-use in event schemas
Closed, ResolvedPublic

Description

Several schemas have a duplicated http field. We want to DRY up this field and $ref it.

This will be used in the new /mediawiki/client/error schema.

https://gerrit.wikimedia.org/r/c/mediawiki/event-schemas/+/544965

Event Timeline

Change 563270 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[schemas/event/primary@master] [WIP] Introduce _fragment/ for common and http

https://gerrit.wikimedia.org/r/563270

@Pchelolo and @Milimetric, what do you think about https://gerrit.wikimedia.org/r/563270?

@jlinehan and I were discussing about how it would be nice to have some kind of clear distinction between real event schemas, and component fragment schemas that are meant to be included. I took this task as a chance of clarifying this.

Would love to hear other ideas than _fragment as a top level namespace. I don't love the underscore in the e.g. /_fragment/http/1.0.0 schema URIs, but it does make the hierarchy much simpler to understand.

I like the idea of separating partial and full schemas very much.

For whatever reason _fragment doesn't sound amazing, but nothing better immediately comes to mind and I don't want to start an endless bikeshedding session on naming, so I will support whatever name you choose.

Change 563270 merged by Ottomata:
[schemas/event/primary@master] Introduce fragment/ schemas for common and http

https://gerrit.wikimedia.org/r/563270

Change 563545 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[operations/deployment-charts@master] eventgate - bump image versions to use latest schema repo versions

https://gerrit.wikimedia.org/r/563545

Change 563545 merged by Ottomata:
[operations/deployment-charts@master] eventgate - bump image versions to use latest schema repo versions

https://gerrit.wikimedia.org/r/563545