Page MenuHomePhabricator
Create Task
Maniphest T242391

Legal Text does not align right to left on Desktop Large Banner
Closed, ResolvedPublic
Actions

Description

Summary:
It was noticed during testing today that the Legal Text does not align right to left in languages that use this orientation, such as Hebrew.

LegalTextNotAlignedRightToLeft.png (516×925 px, 70 KB)

Steps to Reproduce:

  1. Open https://he.wikipedia.org/w/index.php?title=%D7%A0%D7%90%D7%A1%22%D7%90&banner=B1920_0301_mlWW_dsk_p1_lg_cnt&country=IL
  2. Observe Legal Text at the bottom of the banner is still aligned left to right

Expected Results:
We would expect the legal text to align right to left in languages that use this orientation.

Actual Results:
Currently the legal text on Desktop Large banners does not align right to left on languages such as Hebrew that are written in this fashion.

Related Objects

Mentioned Here
P3 nagios-plugin-files

Event Timeline

• jbolorinos-ctr created this task.Jan 9 2020, 11:51 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 9 2020, 11:51 PM
• jbolorinos-ctr removed subscribers: Pcoombe, spatton, Aklapper.Jan 10 2020, 12:04 AM
• jbolorinos-ctr triaged this task as Low priority.Jan 10 2020, 12:07 AM
• jbolorinos-ctr lowered the priority of this task from Low to Lowest.Jan 10 2020, 12:10 AM
Pcoombe moved this task from Backlog to RTL on the Wikimedia-Fundraising-Banners board.Feb 19 2020, 4:59 PM
• jbolorinos-ctr raised the priority of this task from Lowest to Medium.Feb 19 2020, 5:36 PM

Updating priority to P3 since Big Bundle campaign needs this, but only affects one country

• jbolorinos-ctr added a subscriber: spatton.Feb 19 2020, 7:32 PM

@spatton confirmed this issue still appears using this URL - https://he.wikipedia.org/w/index.php?title=%D7%A0%D7%90%D7%A1%22%D7%90&banner=B1920_0301_mlWW_dsk_p1_lg_cnt&country=IL

Legal text now appears correctly translated, but is still aligned incorrectly

• jbolorinos-ctr updated the task description. (Show Details)Feb 19 2020, 7:32 PM
Pcoombe claimed this task.Feb 26 2020, 9:41 PM

@jbolorinos-ctr This should be fixed now, please can you confirm? https://he.wikipedia.org/?banner=B1920_0301_mlWW_dsk_p1_lg_cnt&country=IL

• jbolorinos-ctr closed this task as Resolved.Feb 26 2020, 10:29 PM

Hey @Pcoombe,

Yeah this looks great now! Fix verified (legal text now aligns correctly from RTL).

image.png (502×1 px, 124 KB)

Closing as resolved

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL