Page MenuHomePhabricator
Create Task
Maniphest T242405

Minor formatting fix in JavaScript API edit module
Closed, ResolvedPublic
Actions

Description

Minor formatting fix in /resources/src/mediawiki.api/edit.js:

Replace 3 occurrences of:
console.log( 'Saved! ');

With:
console.log( 'Saved!' );

Aim at improving convenience for people who copy-paste code from the API documentation :)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Minor formatting fix in JavaScript API edit modulemediawiki/coremaster+3 -3
Customize query in gerrit

Event Timeline

Od1n created this task.Jan 10 2020, 3:15 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptJan 10 2020, 3:15 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Od1n removed projects: Wikidata, Wikibase-JavaScript-Api.Jan 10 2020, 3:16 AM
Od1n added a comment.Jan 10 2020, 3:25 AM
This comment was removed by Od1n.
DannyS712 added a project: Patch-For-Review.Jan 10 2020, 3:26 AM
gerritbot added a comment.Jan 10 2020, 3:26 AM

Change 563333 had a related patch set uploaded (by DannyS712; owner: Hank Hulet):
[mediawiki/core@master] Minor formatting fix in JavaScript API edit module

https://gerrit.wikimedia.org/r/563333

DannyS712 subscribed.Jan 10 2020, 3:27 AM
Aklapper added a project: MediaWiki-Action-API.Jan 10 2020, 6:25 AM
Restricted Application added a project: Platform Engineering. · View Herald TranscriptJan 10 2020, 6:25 AM
Od1n updated the task description. (Show Details)Jan 10 2020, 7:22 AM
Anomie removed projects: MediaWiki-Action-API, Platform Engineering.Jan 10 2020, 2:34 PM
Anomie subscribed.

This task is about code that uses MediaWiki-Action-API, not about MediaWiki-Action-API itself. Untagging.

Anomie unsubscribed.Jan 10 2020, 2:34 PM
Aklapper added a project: MediaWiki-General.Jan 10 2020, 4:10 PM
gerritbot added a comment.Jan 10 2020, 5:05 PM

Change 563333 merged by jenkins-bot:
[mediawiki/core@master] Minor formatting fix in JavaScript API edit module

https://gerrit.wikimedia.org/r/563333

matmarex closed this task as Resolved.Jan 10 2020, 5:11 PM
matmarex assigned this task to Od1n.
matmarex subscribed.

Thanks for the patch!

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 10 2020, 6:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits