Page MenuHomePhabricator

wd-shex-infer highlighter doesn't insert comments on Chrome Windows
Open, Needs TriagePublic

Description

https://tools.wmflabs.org/wd-shex-infer/job/8/shex .

On Chrome Android (Samsung phone) it shows highlighting and comments:

wd-shex-infer-highlight-and-comment.jpg (1×1 px, 527 KB)

But on Chrome Version 79.0.3945.88 (Official Build) (64-bit) on Windows 10 the comments don't show and I get this error:

Navigated to https://tools.wmflabs.org/wd-shex-infer/job/8/shex
jstree.js:7235 [Deprecation] document.registerElement is deprecated and will be removed in M80, around February 2020. Please use window.customElements.define instead. See https://www.chromestatus.com/features/4642138092470272 and https://developers.google.com/web/updates/2019/07/web-components-time-to-upgrade for more details.
(anonymous) @ jstree.js:7235
(anonymous) @ jstree.js:7238
(anonymous) @ jstree.js:11
(anonymous) @ jstree.js:13

annotate-wikidata-entity-ids-in-shex.js:4 ShEx element already has 168 child elements, adding Wikidata annotations might break them!
annotateWikidataEntityIdsInShex @ annotate-wikidata-entity-ids-in-shex.js:4
annotateWikidataEntityIdsInShex_default @ annotate-wikidata-entity-ids-in-shex.js:79
(anonymous) @ annotate-wikidata-entity-ids-in-shex.js:86
shex:1 Unchecked runtime.lastError: The message port closed before a response was received.

My chrome says "Nearly up to date! Relaunch Google Chrome to finish updating" so I'll try after relaunching it.

Event Timeline

It’s working fine on my end (Chromium 79.0.3945.117, Arch Linux). I think most of the messages in the console output aren’t from my code – jstree has nothing to do with me, and this “message port closed” message also seems to be some extension thing – so I’m not sure how to debug this. Perhaps you could try with extensions disabled? (Firefox has a “restart with extensions disabled” feature to make that easy, I think, not sure about Chrome.)

I think this is your message: ShEx element already has 168 child elements, adding Wikidata annotations might break them and it points to the reason? I guess you give up generating the comments in this case: but why do you think 168 is too many?
The extra elements probably come from an add on (SingleFile comes to mind) but if you add a couple more to those 168, that would be ok?

That warning is from my code, but you don’t need to worry about it (happens here as well). It doesn’t mean that the code gives up, it just warns you that it might break something and then goes ahead. (168 is the actual number of elements – the syntax highlighting – not a limit.)