Page MenuHomePhabricator
Create Task
Maniphest T242415

EntitySourceDefinitions to use 'sub-entity-type' entity type definition information
Closed, ResolvedPublic
Actions

Description

The relationship between lexemes and forms/senses, e.g. the fact the data of the form is stored in the page related to the lexeme the form belongs to has been codified using the sub-entity-type setting in entity type definitions, see https://github.com/wikimedia/mediawiki-extensions-WikibaseLexeme/blob/master/WikibaseLexeme.entitytypes.php#L80-L83

EntitySourceDefinitions has to make use of this definitions in order to, for example, be able to provide the entity source which provides entities of type form.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
EntitySourceDefitions::getEntityTypeToSourceMapping fix for sub entitiesmediawiki/extensions/Wikibasewmf/1.35.0-wmf.16+6 -0
Test EntitySourceDefitions::getEntityTypeToSourceMapping with subsmediawiki/extensions/Wikibasemaster+26 -4
EntitySourceDefitions::getEntityTypeToSourceMapping fix for sub entitiesmediawiki/extensions/Wikibasemaster+6 -0
Adjust constructor calls in SparqlHelperTestmediawiki/extensions/WikibaseQualityConstraintsmaster+3 -26
Temporarily skip some tests due to on-going changes to Wikibasemediawiki/extensions/WikibaseQualityConstraintsmaster+24 -0
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 Resolved• Ramsey-WMFT199352 Deploy Structured Data on Commons with arbitrary Statements
 ResolvedCparleT204264 "Depicts crawling": Add displaying/editing statements to File page
 ResolvedJdforrester-WMFT218913 Enable Depicts in production
 ResolvedJdforrester-WMFT214075 Enable federated access to entities and properties from Wikidata to Commons
 ResolvedNoneT212144 Allow access to MediaInfo from wikitext on Commons
 InvalidNoneT211800 Resolve ambiguity of entity ID prefixes used on Commons.
 ResolvedWMDE-leszekT214557 Allow accessing Wikibase entities from multiple (Wikibase) databases
 ResolvedNoneT242415 EntitySourceDefinitions to use 'sub-entity-type' entity type definition information

Event Timeline

WMDE-leszek created this task.Jan 10 2020, 10:48 AM
WMDE-leszek moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 10 2020, 11:05 AM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 10 2020, 11:15 AM
gerritbot added a comment.Jan 10 2020, 1:25 PM

Change 563437 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] NOT READY work on T242415

https://gerrit.wikimedia.org/r/563437

gerritbot added a project: Patch-For-Review.Jan 10 2020, 1:25 PM
gerritbot added a comment.Jan 10 2020, 4:43 PM

Change 563437 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/Wikibase@master] Use information on "sub entity types" in EntitySourceDefinitions

https://gerrit.wikimedia.org/r/563437

gerritbot added a comment.Jan 13 2020, 8:56 AM

Change 563960 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseQualityConstraints@master] Temporarily skip some tests due to on-going changes to Wikibase

https://gerrit.wikimedia.org/r/563960

gerritbot added a comment.Jan 13 2020, 8:56 AM

Change 563961 had a related patch set uploaded (by WMDE-leszek; owner: WMDE-leszek):
[mediawiki/extensions/WikibaseQualityConstraints@master] Adjust constructor calls in SparqlHelperTest

https://gerrit.wikimedia.org/r/563961

WMDE-leszek removed WMDE-leszek as the assignee of this task.Jan 13 2020, 9:48 AM
WMDE-leszek moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
WMDE-leszek mentioned this in T241973: wmgUseEntitySourceBasedFederation true for test.wikidata.org.Jan 13 2020, 9:51 AM
Ladsgroup assigned this task to WMDE-leszek.Jan 13 2020, 10:45 AM
WMDE-leszek mentioned this in rEWCSc0115b0ebeb7: Temporarily skip some tests due to on-going changes to Wikibase.Jan 13 2020, 12:12 PM
gerritbot added a comment.Jan 14 2020, 9:53 AM

Change 563960 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Temporarily skip some tests due to on-going changes to Wikibase

https://gerrit.wikimedia.org/r/563960

WMDE-leszek mentioned this in rEBQC764750f2b2c8: Temporarily skip some tests due to on-going changes to Wikibase.Jan 14 2020, 9:54 AM
Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 14 2020, 10:11 AM
WMDE-leszek mentioned this in rEWCSd5bdd44292b2: Adjust constructor calls in SparqlHelperTest.Jan 14 2020, 10:25 AM
gerritbot added a comment.Jan 14 2020, 10:34 AM

Change 563961 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Adjust constructor calls in SparqlHelperTest

https://gerrit.wikimedia.org/r/563961

WMDE-leszek mentioned this in rEBQC098f43252d97: Adjust constructor calls in SparqlHelperTest.Jan 14 2020, 10:36 AM
WMDE-leszek closed this task as Resolved.Jan 16 2020, 12:54 PM
WMDE-leszek removed WMDE-leszek as the assignee of this task.
WMDE-leszek moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
gerritbot added a comment.Jan 23 2020, 12:49 PM

Change 566720 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] EntitySourceDefitions::getEntityTypeToSourceMapping fix for sub entities

https://gerrit.wikimedia.org/r/566720

gerritbot added a comment.Jan 23 2020, 12:51 PM

Change 566721 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.16] EntitySourceDefitions::getEntityTypeToSourceMapping fix for sub entities

https://gerrit.wikimedia.org/r/566721

gerritbot added a comment.Jan 23 2020, 1:46 PM

Change 566732 had a related patch set uploaded (by Addshore; owner: Addshore):
[mediawiki/extensions/Wikibase@master] Test EntitySourceDefitions::getEntityTypeToSourceMapping with subs

https://gerrit.wikimedia.org/r/566732

gerritbot added a comment.Jan 23 2020, 3:26 PM

Change 566720 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] EntitySourceDefitions::getEntityTypeToSourceMapping fix for sub entities

https://gerrit.wikimedia.org/r/566720

gerritbot added a comment.Jan 23 2020, 3:50 PM

Change 566732 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Test EntitySourceDefitions::getEntityTypeToSourceMapping with subs

https://gerrit.wikimedia.org/r/566732

gerritbot added a comment.Jan 23 2020, 3:57 PM

Change 566721 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.16] EntitySourceDefitions::getEntityTypeToSourceMapping fix for sub entities

https://gerrit.wikimedia.org/r/566721

Stashbot added a comment.Jan 23 2020, 4:02 PM

Mentioned in SAL (#wikimedia-operations) [2020-01-23T16:02:40Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.16/extensions/Wikibase/data-access/src/EntitySourceDefinitions.php: [[gerrit:566721|EntitySourceDefitions::getEntityTypeToSourceMapping fix for sub entities (T242415 T214557)]] (duration: 01m 08s)

Stashbot mentioned this in T214557: Allow accessing Wikibase entities from multiple (Wikibase) databases.Jan 23 2020, 4:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits