Page MenuHomePhabricator

Delete 10h16 skin of fundraising application
Closed, ResolvedPublic1 Estimated Story Points

Description

Acceptance Criteria

  • Delete the skin folder
  • Drop the build for the skin
  • Drop node modules and npm build script for skins in the root directory of the application.
  • Cleanup 10h16 related a/b tests.
  • Remove REDUX_LOG variable from Makefile

Fix CI Test Errors

  1. Add a "skin": "laika" configuration entry to config.dist.json
  2. add a "skin":"test" configuration entry to config.test.json
  3. Adapt the JSOn schema for the configuration (adding the skin entry in app/config/schema.json)
  4. Change FunFunFactory:getSkinDirectory to create the skin directory from the configuration instad of the ChoiceFactory (you can copy code from ChoiceFactory::getSkinTemplateDirectory, see other methods of FunFunFactory on how to acces the configuration)
  5. Remove ChoiceFactory::getSkinTemplateDirectory and the skin configuration from app/config/campaigns.yml and app/config/campaigns_test.yml

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gabriel-wmde closed subtask Restricted Task as Declined.
kai.nissen set the point value for this task to 3.
kai.nissen changed the point value for this task from 3 to 1.
AbbanWMDE subscribed.