Page MenuHomePhabricator

[Regression] Tooltip appears misaligned on mobile VE
Closed, ResolvedPublic

Description

Steps to replicate:

  1. Open mobile VE.
  1. Tap on any info icon inside Media Settings dialog.

Observe that, the tooltip is not aligned with the icon but rather appearing at random positions which does not look nice aesthetically.

IMG_5508 2.PNG (2×1 px, 235 KB)

Event Timeline

JTannerWMF added a subscriber: JTannerWMF.

Hey @Ryasmeen, what version of iOS are you running so that the engineers can attempt to reproduce?

JTannerWMF added a subscriber: matmarex.

@ppelberg is on iOS 13.3 and was able to reproduce. @matmarex will take a look at this.

Hey @Ryasmeen, what version of iOS are you running so that the engineers can attempt to reproduce?

Unless specified, the reported bugs are usually not specific to any iOS version. Attempting to reproduce should give the same result.

During Standup we determined that @Esanders and @Ryasmeen will test this together.

The appears to break when the viewport drops below 720px, so likely caused by the DEVICE_WIDTH_TABLET styles.

721px:

image.png (243×713 px, 30 KB)

720px:
image.png (478×696 px, 37 KB)

Looks like the offending styles come from Echo and were introduced in T241090.

Change 571351 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Echo@master] Revert "Style improvements to Echo OOUI dialog in desktop Minerva"

https://gerrit.wikimedia.org/r/571351

Change 571351 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Revert "Style improvements to Echo OOUI dialog in desktop Minerva"

https://gerrit.wikimedia.org/r/571351

Change 571389 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Echo@master] Properly scoped style improvements to Echo OOUI dialog in desktop Minerva

https://gerrit.wikimedia.org/r/571389

Change 571389 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Properly scoped style improvements to Echo OOUI dialog in desktop Minerva

https://gerrit.wikimedia.org/r/571389

marcella awarded a token.