Page MenuHomePhabricator
Create Task
Maniphest T242493

[Regression] Tooltip appears misaligned on mobile VE
Closed, ResolvedPublic
Actions

Assigned To
• marcella
Authored By
Ryasmeen
Jan 11 2020, 12:59 AM
Tags
Referenced Files
F31506411: CdImJPxCQNCtK4P6GXqlxw_thumb_737d.jpg
Feb 10 2020, 7:53 PM
F31555997: image.png
Feb 8 2020, 12:29 AM
F31556000: image.png
Feb 8 2020, 12:29 AM
F31508019: IMG_5508 2.PNG
Jan 11 2020, 12:59 AM
Subscribers
Aklapper
Esanders
JTannerWMF
matmarex
ppelberg
Ryasmeen
Tokens
"Piece of Eight" token, awarded by marcella.

Description

Steps to replicate:

  1. Open mobile VE.
  1. Tap on any info icon inside Media Settings dialog.

Observe that, the tooltip is not aligned with the icon but rather appearing at random positions which does not look nice aesthetically.

IMG_5508 2.PNG (2×1 px, 235 KB)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/Echomaster+49 -1Properly scoped style improvements to Echo OOUI dialog in desktop Minerva
mediawiki/extensions/Echomaster+1 -47Revert "Style improvements to Echo OOUI dialog in desktop Minerva"
Customize query in gerrit

Related Objects

Event Timeline

Ryasmeen created this task.Jan 11 2020, 12:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 11 2020, 12:59 AM
Ryasmeen added a project: VisualEditor.Jan 11 2020, 12:59 AM
JTannerWMF edited projects, added VisualEditor (Current work); removed VisualEditor.Jan 14 2020, 4:34 PM
JTannerWMF added a subscriber: JTannerWMF.

Hey @Ryasmeen, what version of iOS are you running so that the engineers can attempt to reproduce?

JTannerWMF moved this task from Incoming to QA on the VisualEditor (Current work) board.Jan 14 2020, 4:35 PM
JTannerWMF added a project: Editing QA.
JTannerWMF moved this task from QA to Ready for Development on the VisualEditor (Current work) board.Jan 14 2020, 4:37 PM
JTannerWMF added a subscriber: matmarex.

@ppelberg is on iOS 13.3 and was able to reproduce. @matmarex will take a look at this.

JTannerWMF removed a project: Editing QA.Jan 14 2020, 4:37 PM
Ryasmeen added a comment.Jan 14 2020, 7:20 PM
In T242493#5802334, @JTannerWMF wrote:

Hey @Ryasmeen, what version of iOS are you running so that the engineers can attempt to reproduce?

Unless specified, the reported bugs are usually not specific to any iOS version. Attempting to reproduce should give the same result.

DannyS712 added a project: Regression.Feb 3 2020, 5:40 AM
JTannerWMF edited projects, added Editing-team (Q3 2019-2020 Kanban Board); removed VisualEditor (Current work).Feb 5 2020, 12:07 AM
JTannerWMF moved this task from Needs Discussion / Investigation to Upcoming on the Editing-team (Q3 2019-2020 Kanban Board) board.
matmarex added a project: VisualEditor.Feb 5 2020, 1:03 AM
JTannerWMF assigned this task to Esanders.Feb 5 2020, 6:09 PM
JTannerWMF moved this task from Upcoming to Ready for Development on the Editing-team (Q3 2019-2020 Kanban Board) board.

During Standup we determined that @Esanders and @Ryasmeen will test this together.

Esanders added a comment.Feb 8 2020, 12:29 AM

The appears to break when the viewport drops below 720px, so likely caused by the DEVICE_WIDTH_TABLET styles.

721px:

image.png (243×713 px, 30 KB)

720px:
image.png (478×696 px, 37 KB)

Esanders added a comment.Feb 8 2020, 12:32 AM

Looks like the offending styles come from Echo and were introduced in T241090.

Esanders mentioned this in T241090: Echo rendering issues on desktop Minerva, not usable on mobile.Feb 8 2020, 12:32 AM
Esanders mentioned this in T242362: [Regression] None of the options under any drop down are visible on mobile VE .Feb 10 2020, 7:51 PM
Esanders merged a task: T242362: [Regression] None of the options under any drop down are visible on mobile VE .

For testing, this also caused T242362, dropdowns not rendering correctly:

CdImJPxCQNCtK4P6GXqlxw_thumb_737d.jpg (1×726 px, 77 KB)

gerritbot added a comment.Feb 10 2020, 8:23 PM

Change 571351 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Echo@master] Revert "Style improvements to Echo OOUI dialog in desktop Minerva"

https://gerrit.wikimedia.org/r/571351

gerritbot added a project: Patch-For-Review.Feb 10 2020, 8:23 PM
gerritbot added a comment.Feb 10 2020, 8:54 PM

Change 571351 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Revert "Style improvements to Echo OOUI dialog in desktop Minerva"

https://gerrit.wikimedia.org/r/571351

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 10 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 10 2020, 9:10 PM
gerritbot added a comment.Feb 10 2020, 11:41 PM

Change 571389 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/Echo@master] Properly scoped style improvements to Echo OOUI dialog in desktop Minerva

https://gerrit.wikimedia.org/r/571389

gerritbot added a project: Patch-For-Review.Feb 10 2020, 11:41 PM
matmarex moved this task from Ready for Development to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 11 2020, 1:22 AM
gerritbot added a comment.Feb 11 2020, 9:16 AM

Change 571389 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Properly scoped style improvements to Echo OOUI dialog in desktop Minerva

https://gerrit.wikimedia.org/r/571389

Maintenance_bot removed a project: Patch-For-Review.Feb 11 2020, 10:10 AM
matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 11 2020, 3:23 PM
matmarex added a project: Editing QA.Feb 11 2020, 3:37 PM
Ryasmeen moved this task from QA to Ready for Sign Off on the Editing-team (Q3 2019-2020 Kanban Board) board.Feb 11 2020, 10:10 PM
Ryasmeen edited projects, added Verified; removed Editing QA.
matmarex mentioned this in T242368: [Regression] "<" appearing over the text of some table action options .Feb 11 2020, 10:16 PM
matmarex merged a task: T242368: [Regression] "<" appearing over the text of some table action options .Feb 11 2020, 10:49 PM
JTannerWMF reassigned this task from Esanders to • marcella.Feb 12 2020, 12:32 PM

Please close this task

matmarex moved this task from To Triage to Triaged on the VisualEditor board.Feb 12 2020, 5:23 PM
• marcella closed this task as Resolved.Mar 4 2020, 5:21 PM
• marcella awarded a token.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 4 2020, 5:21 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL