Page MenuHomePhabricator
Create Task
Maniphest T242556

Replace IP class with IPUtils (Wikimedia-deployed)
Closed, ResolvedPublic
Actions

Description

The IP class in MW core is deprecated since 1.35, it should be replaced with IPUtils

This will require an use Wikimedia\IPUtils;, and also the required MW version bumping to >= 1.35

Details

SubjectRepoBranchLines +/-
Replace deprecated IP class with IPUtilsmediawiki/extensions/DonationInterfacemaster+3 -2
Replace deprecated IP class with IPUtilsmediawiki/extensions/StopForumSpammaster+7 -7
Replace deprecated IP class with IPUtilsmediawiki/extensions/BounceHandlermaster+5 -2
Replace deprecated IP class with IPUtilsmediawiki/extensions/Nukemaster+4 -2
Replace deprecated IP class with IPUtilsmediawiki/extensions/LandingCheckmaster+7 -1
Replace deprecated IP class with IPUtils in commented-out code.mediawiki/extensions/Jademaster+2 -1
Replace deprecated IP class with IPUtilsmediawiki/extensions/LiquidThreadsmaster+3 -2
Replace deprecated IP class with IPUtilsoperations/mediawiki-configmaster+4 -1
Replace deprecated IP class with IPUtilsmediawiki/extensions/Flowmaster+4 -4
Replace deprecated IP class with IPUtilsmediawiki/extensions/FundraiserLandingPagemaster+5 -2
Replace deprecated IP class with IPUtilsmediawiki/extensions/VipsScalermaster+5 -3
Replace deprecated IP class with IPUtilsmediawiki/extensions/TorBlockmaster+7 -5
Replace deprecated IP class with IP Utilitiesmediawiki/extensions/ConfirmEditmaster+7 -5
Replace deprecated IP class with IP Utilitiesmediawiki/extensions/GlobalUserPagemaster+3 -3
Replace deprecated IP class with IPUtilsmediawiki/extensions/LoginNotifymaster+5 -5
Avoid use of deprecated IP classmediawiki/extensions/ProofreadPagemaster+3 -3
Replace deprecated IP class with IPUtilsmediawiki/extensions/TrustedXFFmaster+5 -3
Bump required MW version to 1.35.0mediawiki/extensions/CheckUsermaster+67 -56
Replace deprecated IP class with IPUtilsmediawiki/extensions/MobileFrontendmaster+7 -4
Replace deprecated IP class with IP Utilitiesmediawiki/extensions/CentralAuthmaster+5 -3
Replace deprecated IP class with IPUtilsmediawiki/extensions/GlobalBlockingmaster+43 -33
Replace deprecated IP class with IP Utilitiesmediawiki/extensions/SecurePollmaster+10 -5
Replace deprecated IP class with IPUtilsmediawiki/extensions/WikimediaMaintenancemaster+4 -2
Replace deprecated IP class with IPUtilsmediawiki/coremaster+6 -5
Replace deprecated IP class with IPUtilsmediawiki/extensions/AbuseFiltermaster+15 -10
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Reedy created this task.Jan 12 2020, 10:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 12 2020, 10:44 PM
Ammarpad subscribed.Jan 13 2020, 5:28 AM
Ammarpad added a comment.Jan 13 2020, 6:01 AM

@Reedy Should I go ahead with this? and do we need a separate task for each extension or all patches should point to this task?

Reedy added a comment.Jan 13 2020, 8:34 AM

No specific reason to create specific tasks, but no reason you can’t either

Reedy added a comment.Jan 13 2020, 9:02 AM

I see ~165 usages

5 in core (including comments), 140 in extensions (plus 10 imports which obviously just need swapping over), in 31 extensions

gerritbot added a comment.Jan 24 2020, 5:15 PM

Change 567099 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/CheckUser@master] Bump required MW version to 1.35.0

https://gerrit.wikimedia.org/r/567099

gerritbot added a project: Patch-For-Review.Jan 24 2020, 5:15 PM
gerritbot added a comment.Jan 24 2020, 5:27 PM

Change 567101 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/AbuseFilter@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/567101

Ammarpad triaged this task as Medium priority.Jan 24 2020, 5:36 PM
Ammarpad removed a project: Google-Code-in-2019.
gerritbot added a comment.Jan 24 2020, 6:00 PM

Change 567110 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/567110

gerritbot added a comment.Jan 24 2020, 6:44 PM

Change 567101 merged by jenkins-bot:
[mediawiki/extensions/AbuseFilter@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/567101

gerritbot added a comment.Jan 24 2020, 7:30 PM

Change 567110 merged by jenkins-bot:
[mediawiki/core@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/567110

gerritbot added a comment.Jan 25 2020, 5:50 AM

Change 567193 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[operations/mediawiki-config@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/567193

gerritbot added a comment.Jan 25 2020, 6:04 AM

Change 567194 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/WikimediaMaintenance@master] Bump required version to MW 1.35.0

https://gerrit.wikimedia.org/r/567194

gerritbot added a comment.Jan 25 2020, 10:03 AM

Change 567194 merged by jenkins-bot:
[mediawiki/extensions/WikimediaMaintenance@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/567194

Jdforrester-WMF added a project: MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Jan 26 2020, 1:16 AM
gerritbot added a comment.Jan 26 2020, 1:07 PM

Change 567336 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/SecurePoll@master] Replace deprecated IP class with IP Utilities

https://gerrit.wikimedia.org/r/567336

gerritbot added a comment.Jan 26 2020, 1:21 PM

Change 567338 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/GlobalBlocking@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/567338

gerritbot added a comment.Jan 26 2020, 1:31 PM

Change 567340 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/CentralAuth@master] Replace deprecated IP class with IP Utilities

https://gerrit.wikimedia.org/r/567340

gerritbot added a comment.Jan 26 2020, 4:33 PM

Change 567336 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Replace deprecated IP class with IP Utilities

https://gerrit.wikimedia.org/r/567336

gerritbot added a comment.Jan 26 2020, 6:20 PM

Change 567340 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Replace deprecated IP class with IP Utilities

https://gerrit.wikimedia.org/r/567340

gerritbot added a comment.Jan 26 2020, 6:21 PM

Change 567338 merged by jenkins-bot:
[mediawiki/extensions/GlobalBlocking@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/567338

Legoktm awarded a token.Jan 26 2020, 10:23 PM
gerritbot added a comment.Jan 27 2020, 4:09 PM

Change 567471 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/MobileFrontend@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/567471

gerritbot added a comment.Jan 28 2020, 9:44 AM

Change 567471 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/567471

gerritbot added a comment.Jan 29 2020, 11:27 PM

Change 567099 merged by jenkins-bot:
[mediawiki/extensions/CheckUser@master] Bump required MW version to 1.35.0

https://gerrit.wikimedia.org/r/567099

gerritbot added a comment.Feb 9 2020, 6:27 AM

Change 571031 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/ProofreadPage@master] Avoid use of deprecated IP class

https://gerrit.wikimedia.org/r/571031

gerritbot added a comment.Feb 9 2020, 6:34 AM

Change 571032 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/LoginNotify@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571032

gerritbot added a comment.Feb 9 2020, 6:57 AM

Change 571033 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/TrustedXFF@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571033

gerritbot added a comment.Feb 9 2020, 7:05 AM

Change 571034 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/ConfirmEdit@master] Replace deprecated IP class with IP Utilities

https://gerrit.wikimedia.org/r/571034

gerritbot added a comment.Feb 9 2020, 7:07 AM

Change 571035 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/Flow@master] Bug: T242556

https://gerrit.wikimedia.org/r/571035

gerritbot added a comment.Feb 9 2020, 7:10 AM

Change 571035 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/Flow@master] Replace deprecated IP class with IP Utilities

https://gerrit.wikimedia.org/r/571035

gerritbot added a comment.Feb 9 2020, 7:17 AM

Change 571031 merged by jenkins-bot:
[mediawiki/extensions/ProofreadPage@master] Avoid use of deprecated IP class

https://gerrit.wikimedia.org/r/571031

gerritbot added a comment.Feb 9 2020, 7:17 AM

Change 571032 merged by jenkins-bot:
[mediawiki/extensions/LoginNotify@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571032

gerritbot added a comment.Feb 9 2020, 7:17 AM

Change 571033 merged by jenkins-bot:
[mediawiki/extensions/TrustedXFF@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571033

gerritbot added a comment.Feb 9 2020, 7:42 AM

Change 571036 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/GlobalUserPage@master] Replace deprecated IP class with IP Utilities

https://gerrit.wikimedia.org/r/571036

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.19; 2020-02-11); removed MW-1.35-notes (1.35.0-wmf.18; 2020-02-04).Feb 9 2020, 8:00 AM
gerritbot added a comment.Feb 9 2020, 11:46 AM

Change 571036 merged by jenkins-bot:
[mediawiki/extensions/GlobalUserPage@master] Replace deprecated IP class with IP Utilities

https://gerrit.wikimedia.org/r/571036

gerritbot added a comment.Feb 9 2020, 4:45 PM

Change 571034 merged by jenkins-bot:
[mediawiki/extensions/ConfirmEdit@master] Replace deprecated IP class with IP Utilities

https://gerrit.wikimedia.org/r/571034

gerritbot added a comment.Feb 10 2020, 3:53 PM

Change 571310 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/VipsScaler@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571310

gerritbot added a comment.Feb 10 2020, 4:00 PM

Change 571313 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/TorBlock@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571313

gerritbot added a comment.Feb 10 2020, 7:11 PM

Change 571313 merged by jenkins-bot:
[mediawiki/extensions/TorBlock@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571313

gerritbot added a comment.Feb 10 2020, 7:11 PM

Change 571310 merged by jenkins-bot:
[mediawiki/extensions/VipsScaler@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571310

gerritbot added a comment.Feb 11 2020, 5:28 AM

Change 571414 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/FundraiserLandingPage@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571414

gerritbot added a comment.Feb 11 2020, 7:42 PM

Change 571035 merged by jenkins-bot:
[mediawiki/extensions/Flow@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571035

gerritbot added a comment.Feb 11 2020, 7:42 PM

Change 571414 merged by jenkins-bot:
[mediawiki/extensions/FundraiserLandingPage@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571414

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.20; 2020-02-18); removed MW-1.35-notes (1.35.0-wmf.19; 2020-02-11).Feb 11 2020, 8:00 PM
Jdforrester-WMF updated the task description. (Show Details)Feb 12 2020, 7:04 PM
gerritbot added a comment.Feb 12 2020, 7:09 PM

Change 567193 merged by jenkins-bot:
[operations/mediawiki-config@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/567193

gerritbot added a comment.Feb 13 2020, 10:16 AM

Change 571941 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/LiquidThreads@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571941

gerritbot added a comment.Feb 13 2020, 10:22 AM

Change 571942 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/LandingCheck@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571942

gerritbot added a comment.Feb 13 2020, 4:32 PM

Change 571413 had a related patch set uploaded (by Jforrester; owner: Ammarpad):
[mediawiki/extensions/Jade@master] Replace deprecated IP class with IPUtils in commented-out code.

https://gerrit.wikimedia.org/r/571413

gerritbot added a comment.Feb 13 2020, 4:36 PM

Change 571413 merged by jenkins-bot:
[mediawiki/extensions/Jade@master] Replace deprecated IP class with IPUtils in commented-out code.

https://gerrit.wikimedia.org/r/571413

gerritbot added a comment.Feb 13 2020, 4:36 PM

Change 571941 merged by jenkins-bot:
[mediawiki/extensions/LiquidThreads@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571941

gerritbot added a comment.Feb 13 2020, 6:40 PM

Change 571942 merged by jenkins-bot:
[mediawiki/extensions/LandingCheck@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/571942

gerritbot added a comment.Feb 14 2020, 6:07 PM

Change 572293 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/DonationInterface@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/572293

gerritbot added a comment.Feb 16 2020, 7:12 AM

Change 572479 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/BounceHandler@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/572479

gerritbot added a comment.Feb 16 2020, 7:16 AM

Change 572482 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/Nuke@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/572482

gerritbot added a comment.Feb 18 2020, 9:16 PM

Change 572482 merged by jenkins-bot:
[mediawiki/extensions/Nuke@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/572482

gerritbot added a comment.Feb 18 2020, 9:17 PM

Change 572479 merged by jenkins-bot:
[mediawiki/extensions/BounceHandler@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/572479

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.21; 2020-02-25); removed MW-1.35-notes (1.35.0-wmf.20; 2020-02-18).Feb 18 2020, 10:01 PM
gerritbot added a comment.Mar 7 2020, 6:23 AM

Change 577727 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/StopForumSpam@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/577727

Ammarpad renamed this task from Replace IP class with IPUtils to Replace IP class with IPUtils (Wikimedia-deployed).Mar 7 2020, 6:45 AM
Ammarpad updated the task description. (Show Details)
Reedy added a project: archived-IPUtils.Mar 7 2020, 11:33 AM
gerritbot added a comment.Mar 7 2020, 11:38 AM

Change 577727 merged by jenkins-bot:
[mediawiki/extensions/StopForumSpam@master] Replace deprecated IP class with IPUtils

https://gerrit.wikimedia.org/r/577727

gerritbot added a comment.Mar 8 2020, 7:23 AM

Change 572293 abandoned by Ammarpad:
Replace deprecated IP class with IPUtils

Reason:
Not needed for now

https://gerrit.wikimedia.org/r/572293

Ammarpad closed this task as Resolved.Mar 8 2020, 7:24 AM
Ammarpad claimed this task.

All done for now, save donation interface which is not feasible now.

Ammarpad mentioned this in T247155: Replace IP class with IPUtils (General).Mar 12 2020, 4:35 PM
Krinkle edited projects, added mediawiki-libs-IPUtils; removed archived-IPUtils.Jan 3 2024, 3:05 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL