Page MenuHomePhabricator

babel update breaks compatibility with npm 3.8.x
Closed, ResolvedPublic

Description

An as-yet unidentified update to babel released across several modules in 7.8.0 breaks CI builds that use the npm-node-6-docker image (that is to say, most or all services still on node 6):

14:03:04 + exec docker run --volume /srv/jenkins/workspace/workspace/mobileapps-periodic-test/src:/src --volume /srv/jenkins/workspace/workspace/mobileapps-periodic-test/cache:/cache --volume /srv/jenkins/workspace/workspace/mobileapps-periodic-test/log:/log --init --rm --label jenkins.job=mobileapps-periodic-test --label jenkins.build=14587 --env-file /dev/fd/63 docker-registry.wikimedia.org/releng/npm-test:0.6.1-s1 periodic
14:03:04 ++ /usr/bin/env
14:03:04 ++ egrep -v '^(HOME|SHELL|PATH|LOGNAME|MAIL)='
14:03:05 + cd /src
14:03:05 + '[' '!' -f package.json ']'
14:03:05 + node --version
14:03:05 v6.11.0
14:03:05 + npm --version
14:03:05 3.8.3
14:03:05 + rm -rf node_modules
14:03:05 + npm install --no-progress
14:03:13 npm WARN deprecated kad-fs@0.0.4: Please upgrade to @kadenceproject/kadence - See https://kadence.github.io
14:03:13 npm WARN deprecated kad-memstore@0.0.1: Please upgrade to @kadenceproject/kadence - See https://kadence.github.io
14:03:16 npm ERR! Linux 4.9.0-0.bpo.11-amd64
14:03:16 npm ERR! argv "/usr/bin/nodejs" "/usr/local/bin/npm" "install" "--no-progress"
14:03:16 npm ERR! node v6.11.0
14:03:16 npm ERR! npm  v3.8.3
14:03:16 npm ERR! code EMISSINGARG
14:03:16 
14:03:16 npm ERR! typeerror Error: Missing required argument #1
14:03:16 npm ERR! typeerror     at andLogAndFinish (/usr/local/lib/node_modules/npm/lib/fetch-package-metadata.js:31:3)
14:03:16 npm ERR! typeerror     at fetchPackageMetadata (/usr/local/lib/node_modules/npm/lib/fetch-package-metadata.js:51:22)
14:03:16 npm ERR! typeerror     at resolveWithNewModule (/usr/local/lib/node_modules/npm/lib/install/deps.js:455:12)
14:03:16 npm ERR! typeerror     at /usr/local/lib/node_modules/npm/lib/install/deps.js:456:7
14:03:16 npm ERR! typeerror     at /usr/local/lib/node_modules/npm/node_modules/iferr/index.js:13:50
14:03:16 npm ERR! typeerror     at /usr/local/lib/node_modules/npm/lib/fetch-package-metadata.js:37:12
14:03:16 npm ERR! typeerror     at addRequestedAndFinish (/usr/local/lib/node_modules/npm/lib/fetch-package-metadata.js:82:5)
14:03:16 npm ERR! typeerror     at returnAndAddMetadata (/usr/local/lib/node_modules/npm/lib/fetch-package-metadata.js:117:7)
14:03:16 npm ERR! typeerror     at pickVersionFromRegistryDocument (/usr/local/lib/node_modules/npm/lib/fetch-package-metadata.js:134:20)
14:03:16 npm ERR! typeerror     at /usr/local/lib/node_modules/npm/node_modules/iferr/index.js:13:50
14:03:16 npm ERR! typeerror This is an error with npm itself. Please report this error at:
14:03:16 npm ERR! typeerror     <http://github.com/npm/npm/issues>

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 563981 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/services/mobileapps@master] Hold back various dependencies for node/npm version compatibility

https://gerrit.wikimedia.org/r/563981

Change 563981 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Hold back various dependencies for node/npm version compatibility

https://gerrit.wikimedia.org/r/563981

Let's figure out who to bug about updating the npm version in the npm-node-6-docker image.

Mholloway lowered the priority of this task from High to Medium.Jan 15 2020, 4:41 PM

We're going up to node 10 soon and there's no point bothering with this further in the meantime.