See parent task
Description
Details
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | DannyS712 | T247793 Non-WMF deployed extensions need uses of global $wgUser removed [tracking] | |||
| Resolved | DannyS712 | T244453 Social tools extensions need uses of global $wgUser removed [tracking] | |||
| Resolved | DannyS712 | T242679 SocialProfile needs uses of global $wgUser removed |
Event Timeline
Change 564140 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SocialProfile@master] Remove use of global $wgUser (part 1)
Change 564140 abandoned by DannyS712:
Remove use of global $wgUser (part 1)
Reason:
Per comment
@ashley is actor support for SocialProfile done? The task summary says no, buthttps://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/SocialProfile/+/565779/ has been merged
Largely done, yes; ditto for other social tools, naturally. I'm keeping the task open for a little while longer in case if some issues resulting from the actor patch still pop up. If there's code you wish to commit, please feel free to! The actor work is no longer blocking anything, even if I'm keeping the ticket open.
There's at least one pretty major actor-related issue, currently not even tracked on Phab, that needs fixing for many social tools: in the case of an extension like MediaWiki-extensions-Comments which allows anonymous users to perform actions, it's possible that an anonymous user has only ever left comments but performed no other actions on the wiki. In this case the actor table doesn't contain an entry for that user, and the migration scripts get confused. This is also true for other extensions like VoteNY and maybe even extensions like BlogPage or PollNY ...
Change 574925 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SocialProfile@master] Remove uses of global $wgUser
Change 574926 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SocialProfile@master] Remove uses of global $wgUser (part 2)
Change 574929 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SocialProfile@master] Remove use of global $wgUser (part 3)
Change 574925 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Remove uses of global $wgUser (part 1)
@ashley I was going to update UserProfile::getProfileComplete to accept a user as a parameter as part 4, but it doesn't seem to have any calls: https://codesearch.wmflabs.org/search/?q=getProfileComplete&i=nope&files=&repos=
Is it safe to remove?
Change 574936 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SocialProfile@master] Remove uses of global $wgUser (part 4)
Change 574937 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SocialProfile@master] Remove uses of global $wgUser (part 5)
Change 574926 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Remove uses of global $wgUser (part 2)
Change 574929 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Remove uses of global $wgUser (part 3)
getProfileComplete was originally used by various ArmchairGM skins; as the current documentation notes, it is indeed unused currently but, I quote, "looks useful enough to be kept around". You should be able to swap the global $wgUser to $this->user in that method to update it to have the global removed since it's not a static method.
Change 575291 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/SocialProfile@master] Remove uses of global $wgUser (part 6)
Change 574936 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Remove uses of global $wgUser (part 4)
Change 574937 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Remove uses of global $wgUser (part 5)
Change 575291 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Remove uses of global $wgUser (part 6)
Change 638187 had a related patch set uploaded (by DannyS712; owner: Jack Phoenix):
[mediawiki/extensions/SocialProfile@master] Don't use $wgUser in GenerateTopUsersReport::createReportPage
Change 638187 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Don't use $wgUser in GenerateTopUsersReport::createReportPage