Page MenuHomePhabricator

Add .phpunit.result.cache to .gitignore
Closed, ResolvedPublic

Description

With PHPUnit 8 knocking at our doors, we should add .phpunit.result.cache to .gitignore. This should be done where the following conditions are met:

  • A .phpunit.xml(.dist) file (or more than one) exists; .phpunit.result.cache will be created by PHPUnit in the same directory as the XML file. Hence, for each XML file, the line to add is $xmlBaseDir/.phpunit.result.cache.
  • If the repo requires PHPUnit >= 8; we may as well ignore this requirement, since all repos will require it sooner or later.

Details

Related Gerrit Patches:

Event Timeline

Daimona created this task.Jan 14 2020, 10:27 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2020, 10:27 AM

There's only a handful of repos that directly install PHPUnit (and most of those probably shouldn't), but sure.

There's only a handful of repos that directly install PHPUnit (and most of those probably shouldn't), but sure.

Note that this list doesn't include libraries and the like. This change was discussed for Equivset (here), but everything in mediawiki/libs and mediawiki/tools (at least) is probably affected.

Change 564741 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[labs/libraryupgrader@master] Add .phpunit.result.cache to .gitignore if phpunit is installed

https://gerrit.wikimedia.org/r/564741

There's only a handful of repos that directly install PHPUnit (and most of those probably shouldn't), but sure.

Note that this list doesn't include libraries and the like. This change was discussed for Equivset (here), but everything in mediawiki/libs and mediawiki/tools (at least) is probably affected.

Hmm. I thought mediawiki/libs/* was index in CS? Oh dear.

Change 564741 merged by jenkins-bot:
[labs/libraryupgrader@master] Add .phpunit.result.cache to .gitignore if phpunit is installed

https://gerrit.wikimedia.org/r/564741

Legoktm closed this task as Resolved.Jan 21 2020, 7:34 AM
Legoktm claimed this task.