Page MenuHomePhabricator

Step 1: bail-out path for novalue/somevalue in the main snak (impact: medium)
Closed, ResolvedPublic5 Estimated Story Points

Description

As an editor I want to be able to edit all data that is shown to me in the Bridge.

Problem:
We don't support editing of all values. We need to allow a bail-out to Wikidata for those cases so the editors can still edit this data.

Screenshots/mockups:
unknown/Some value


No value

BDD
GIVEN a statement with a special (somevalue or novalue) value
WHEN trying to edit it
THEN an message is shown leading the editor to edit on the repository instead

Acceptance criteria:

  • trying to edit a statement with a special value (novalue of somevalue) results in a screen telling the editor to go to the repository
  • hierarchy of bail-outs is datatype -> multiple values -> special value -> rank

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2020, 1:07 PM
Lydia_Pintscher set the point value for this task to 5.Jan 14 2020, 1:07 PM
Restricted Application added a project: Wikidata. · View Herald TranscriptJan 14 2020, 1:08 PM
Lydia_Pintscher triaged this task as High priority.Jan 14 2020, 1:10 PM
Lydia_Pintscher moved this task from Backlog to Ready to pick up on the Wikidata-Bridge board.

Change 570356 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: add bailout for somevalue/novalue statements

https://gerrit.wikimedia.org/r/570356

Change 570634 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: WIP: show property labels in bailout components

https://gerrit.wikimedia.org/r/570634

Change 570356 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: add bailout for somevalue/novalue statements

https://gerrit.wikimedia.org/r/570356

Change 570634 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: show property labels in bailout components

https://gerrit.wikimedia.org/r/570634

Change 570921 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] bridge: fix vertical marging of bailout heading

https://gerrit.wikimedia.org/r/570921

Change 570921 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: fix vertical marging of bailout heading

https://gerrit.wikimedia.org/r/570921

Charlie_WMDE closed this task as Resolved.Feb 10 2020, 12:45 PM
Charlie_WMDE moved this task from Verification to Done on the Wikidata-Bridge-Sprint-13 board.
Charlie_WMDE added a subscriber: Charlie_WMDE.

cool! looks good to me!

sorry, i moved this already but i actually have one more question: the link on the beta page sais "somevalue statement" but the modal then sais "unknown value". Is this a mixup or am i missing smth? @Lucas_Werkmeister_WMDE

somevalue is the internal name of “unknown value”. No mixup :)

wait, but they're two distinct things. there's some value/unknown value, and no value. they are not the same, no?

You’re right – I’ve added a separate novalue link now.

cool! thank you!