Page MenuHomePhabricator

Newcomer tasks: mobile - Topic filters check marks overlaps labels
Open, Needs TriagePublic

Description

Found by @MMiller_WMF. It seems not reproducible in a browser emulators (tired FF, Chrome, Safari and Sauce labs and Xcode simulators).

Consistently reproducible in iPhone 6s real device (iOS 13.3.1)

  1. In Homepage Suggested edits filter selection, click to select some filters - the check marks will overlap the labels

  1. Click on 'Done' and then open the filter selection again - the checkmarks are positioned correctly.

  1. Make some new filter selection - the check marks will be overlapping again.

Here is a video from a real device - it shows an additional shift in the label attempting and failing to accommodate the check mark.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2020, 11:04 PM
MMiller_WMF renamed this task from Newcomer tasks: mobile - Topc filters check marks overlaps labels to Newcomer tasks: mobile - Topic filters check marks overlaps labels.Jan 15 2020, 1:15 AM
MMiller_WMF added subscribers: kostajh, RHo, Tgr and 2 others.

We should try to fix this before deploying V1.1.0. Ready for Development.

@kostajh @Tgr @Catrope -- I just noticed that this was mistakenly buried too far in Ready for Development. Could we please prioritize it?

I can't reproduce this on desktop Chrome (with or without mobile emulator), desktop Firefox (with or without mobile emulator), or mobile Chrome (on Android). Does this only happen on iPhones? Does it happen in desktop Safari too?

Also note that in the screenshot, it doesn't happen to all topics: "Geografie" isn't broken.

@Etonkovidova -- the question from @Catrope is for you.

It doesn't occur in the start editing dialog, so that's maybe a clue on how to fix it.

I can't reproduce this on desktop Chrome (with or without mobile emulator), desktop Firefox (with or without mobile emulator), or mobile Chrome (on Android). Does this only happen on iPhones? Does it happen in desktop Safari too?

Also note that in the screenshot, it doesn't happen to all topics: "Geografie" isn't broken.

Safari desktop doesn't have this issue. And it seems not to be reproducible in any of the simulators - I added more details to the task description and the video from iPhone.