Page MenuHomePhabricator
Create Task
Maniphest T242808

Newcomer tasks: mobile - Topic filters check marks overlaps labels
Open, Needs TriagePublic
Actions

Description

Found by @MMiller_WMF. It seems not reproducible in a browser emulators (tired FF, Chrome, Safari and Sauce labs and Xcode simulators).

Consistently reproducible in iPhone 6s real device (iOS 13.3.1)

  1. In Homepage Suggested edits filter selection, click to select some filters - the check marks will overlap the labels

IMG_8695.PNG (1×640 px, 116 KB)

  1. Click on 'Done' and then open the filter selection again - the checkmarks are positioned correctly.

IMG_8696.PNG (1×640 px, 136 KB)

  1. Make some new filter selection - the check marks will be overlapping again.

Here is a video from a real device - it shows an additional shift in the label attempting and failing to accommodate the check mark.

check_marks_iphone.mp4944 KBDownload

Related Objects
Search...

Event Timeline

Etonkovidova created this task.Jan 14 2020, 11:04 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2020, 11:04 PM
MMiller_WMF renamed this task from Newcomer tasks: mobile - Topc filters check marks overlaps labels to Newcomer tasks: mobile - Topic filters check marks overlaps labels.Jan 15 2020, 1:15 AM
MMiller_WMF added a parent task: T238612: Newcomer tasks: topic filters.
MMiller_WMF edited projects, added NewcomerTasks 1.1, Growth-Team (Sprint 0 (Growth Team)); removed GrowthExperiments, Growth-Team.
MMiller_WMF moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.
MMiller_WMF added subscribers: kostajh, RHo, Tgr and 2 others.

We should try to fix this before deploying V1.1.0. Ready for Development.

MMiller_WMF added a comment.Jan 16 2020, 10:11 PM

@kostajh @Tgr @Catrope -- I just noticed that this was mistakenly buried too far in Ready for Development. Could we please prioritize it?

Catrope added a comment.Jan 17 2020, 1:59 AM

I can't reproduce this on desktop Chrome (with or without mobile emulator), desktop Firefox (with or without mobile emulator), or mobile Chrome (on Android). Does this only happen on iPhones? Does it happen in desktop Safari too?

Also note that in the screenshot, it doesn't happen to all topics: "Geografie" isn't broken.

MMiller_WMF added a comment.Jan 18 2020, 12:12 AM

@Etonkovidova -- the question from @Catrope is for you.

kostajh added a comment.Feb 12 2020, 9:18 PM

It doesn't occur in the start editing dialog, so that's maybe a clue on how to fix it.

Etonkovidova updated the task description. (Show Details)Feb 13 2020, 12:10 AM
In T242808#5811800, @Catrope wrote:

I can't reproduce this on desktop Chrome (with or without mobile emulator), desktop Firefox (with or without mobile emulator), or mobile Chrome (on Android). Does this only happen on iPhones? Does it happen in desktop Safari too?

Also note that in the screenshot, it doesn't happen to all topics: "Geografie" isn't broken.

Safari desktop doesn't have this issue. And it seems not to be reproducible in any of the simulators - I added more details to the task description and the video from iPhone.

Etonkovidova mentioned this in T247308: Deploy suggested edits on uk, hu, hy, eu wikis.Apr 9 2020, 7:46 PM
MMiller_WMF edited projects, added Growth-Team; removed Growth-Team (Sprint 0 (Growth Team)).Oct 8 2020, 4:51 AM

De-prioritizing off the sprint board in favor of other priorities.

MMiller_WMF moved this task from Inbox to Upcoming Work on the Growth-Team board.Oct 8 2020, 4:51 AM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL