[betalabs] Newcomer tasks: mobile - task explanation drawer is not present
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Etonkovidova
	Jan 14 2020, 11:18 PM

Description

@MMiller_WMF found the issue - it's betalabs regression; the info button works in production.

On betalabs cswiki mobile click on info button ("oo-ui-iconElement-icon oo-ui-icon-info" ) in Suggested edits module - nothing happens.

Expected result: (from wmf.14)

Screen Shot 2020-01-14 at 3.12.22 PM.png (688×401 px, 121 KB)

Details

	Subject	Repo	Branch	Lines +/-
	Fix suggestededits drawer	mediawiki/extensions/GrowthExperiments	wmf/1.35.0-wmf.15	+15 -14
	Fix suggestededits drawer	mediawiki/extensions/GrowthExperiments	master	+15 -14

Customize query in gerrit

Related Objects

Mentioned In: T242052: Newcomer tasks: topic matching instrumentation
Mentioned Here: T242052: Newcomer tasks: topic matching instrumentation
rEMFR3116c170c0e3: Drawer's no longer touch the body tag and have their own mask

Event Timeline

Etonkovidova created this task.Jan 14 2020, 11:18 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 14 2020, 11:18 PM

MMiller_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jan 15 2020, 6:37 PM

Seems important to fix soon.

In wmf.14, clicking on the explanation icon shows this in the console:

Caller of Drawer should use onShow prop and append Drawer itself.
Please pass the onShow method to the Drawer
Please use the onShow method for scroll/close behaviour of Drawer

Whereas this doesn't show in wmf.15, so perhaps something was changed/removed upstream?

Indeed, this broke with 3116c170c0e303df968ba4a118616a2e91ed7eed

Tgr claimed this task.Jan 16 2020, 2:50 AM

Tgr moved this task from Ready for Development to In Progress on the Growth-Team (Sprint 0 (Growth Team)) board.

Change 565188 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix suggestededits drawer

https://gerrit.wikimedia.org/r/565188

gerritbot added a project: Patch-For-Review.Jan 16 2020, 6:01 AM

Tgr moved this task from In Progress to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 16 2020, 6:03 AM

Change 565188 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix suggestededits drawer

https://gerrit.wikimedia.org/r/565188

Maintenance_bot removed a project: Patch-For-Review.Jan 16 2020, 9:10 AM

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Jan 16 2020, 9:18 AM

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 16 2020, 10:00 AM

Etonkovidova closed this task as Resolved.Jan 16 2020, 9:50 PM

Change 565695 had a related patch set uploaded (by Catrope; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.15] Fix suggestededits drawer

https://gerrit.wikimedia.org/r/565695

gerritbot added a project: Patch-For-Review.Jan 17 2020, 9:45 PM

Change 565695 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@wmf/1.35.0-wmf.15] Fix suggestededits drawer

https://gerrit.wikimedia.org/r/565695

Mentioned in SAL (#wikimedia-operations) [2020-01-22T00:26:53Z] <catrope@deploy1001> Synchronized php-1.35.0-wmf.15/extensions/GrowthExperiments/: SWAT for T242811, T242052 (duration: 01m 05s)

Stashbot mentioned this in T242052: Newcomer tasks: topic matching instrumentation.Jan 22 2020, 12:26 AM

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.15; 2020-01-14); removed MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 22 2020, 1:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2020, 1:10 AM

	F31512686: Screen Shot 2020-01-14 at 3.12.22 PM.png
	Jan 14 2020, 11:18 PM

[betalabs] Newcomer tasks: mobile - task explanation drawer is not present Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

[betalabs] Newcomer tasks: mobile - task explanation drawer is not present
Closed, ResolvedPublic
Actions