PHP Warning: "in_array() expects parameter 2 to be array" from Special:GlobalRenameRequest
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	• LarsWirzenius
	Jan 15 2020, 2:22 PM

Description

Error

MediaWiki version: 1.35.0-wmf.15

message

PHP Warning: in_array() expects parameter 2 to be array, null given

exception.trace

#0 [internal function]: MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.35.0-wmf.15/extensions/CentralAuth/includes/GlobalRename/GlobalRenameBlacklist.php(124): in_array(string, NULL, boolean)
#2 /srv/mediawiki/php-1.35.0-wmf.15/extensions/CentralAuth/includes/specials/SpecialGlobalRenameRequest.php(40): GlobalRenameBlacklist->checkUser(User)
#3 /srv/mediawiki/php-1.35.0-wmf.15/includes/specialpage/SpecialPage.php(316): SpecialGlobalRenameRequest->userCanExecute(User)
#4 /srv/mediawiki/php-1.35.0-wmf.15/includes/specialpage/FormSpecialPage.php(207): SpecialPage->checkPermissions()
#5 /srv/mediawiki/php-1.35.0-wmf.15/includes/specialpage/FormSpecialPage.php(179): FormSpecialPage->checkExecutePermissions(User)
#6 /srv/mediawiki/php-1.35.0-wmf.15/extensions/CentralAuth/includes/specials/SpecialGlobalRenameRequest.php(98): FormSpecialPage->execute(NULL)
#7 /srv/mediawiki/php-1.35.0-wmf.15/includes/specialpage/SpecialPage.php(575): SpecialGlobalRenameRequest->execute(NULL)
#8 /srv/mediawiki/php-1.35.0-wmf.15/includes/specialpage/SpecialPageFactory.php(611): SpecialPage->run(NULL)
#9 /srv/mediawiki/php-1.35.0-wmf.15/includes/MediaWiki.php(298): MediaWiki\Special\SpecialPageFactory->executePath(Title, RequestContext)
#10 /srv/mediawiki/php-1.35.0-wmf.15/includes/MediaWiki.php(967): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.35.0-wmf.15/includes/MediaWiki.php(530): MediaWiki->main()
#12 /srv/mediawiki/php-1.35.0-wmf.15/index.php(46): MediaWiki->run()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}

Impact

Happened once so far in this week's train. Probably not a huge problem, but seems like a clear programming error, so I report it so it doesn't get overlooked.

Notes

Details

Request ID: Xh8e3QpAAEAAACUbinkAAAFJ
Request URL: https://meta.wikimedia.org/wiki/Special:GlobalRenameRequest

Related Objects

Mentioned Here: T242974: PHP Warning: Invalid argument supplied for foreach()
rECAUc18695aa7079: Introduce a blacklist of users who cannot use Special:GlobalRenameRequest

Event Timeline

• LarsWirzenius created this task.Jan 15 2020, 2:22 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2020, 2:22 PM

Reproducible when loading https://meta.wikimedia.org/wiki/Special:GlobalRenameRequest but no obvious user impact.

brennen added projects: MediaWiki-extensions-CentralAuth, User-brennen.Jan 15 2020, 2:30 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.

Krinkle renamed this task from PHP Warning: in_array() expects parameter 2 to be array, null given to PHP Warning: "in_array() expects parameter 2 to be array" from Special:GlobalRenameRequest.Jan 23 2020, 11:40 AM

Krinkle updated the task description. (Show Details)

Krinkle edited Stack Trace. (Show Details)

This code block at GlobalRenameBlacklist.php:L124 was recently introduced, as such most likely a regression. Raising priority as such.

• LarsWirzenius unsubscribed.Feb 20 2020, 3:38 PM

I would say this is fixed with fix for T242974

Seems so. Grepped logs, don't see that happening. Let's close?

Sure.

PHP Warning: "in_array() expects parameter 2 to be array" from Special:GlobalRenameRequestClosed, ResolvedPublicPRODUCTION ERRORActions