PHP Warning: Invalid argument supplied for foreach()
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.35.0-wmf.15

message

PHP Warning: Invalid argument supplied for foreach()

Impact

Happened during this week's train. Not a lot of times. Doesn't seem urgent, but reporting anyway so it's not forgotten, as it seems like a clear programming error.

Notes

Details

Request ID: Xh8eTApAEMMAAAjli0EAAABL
Request URL: https://ca.wikipedia.org/w/api.php

Stack Trace

exception.trace

#0 /srv/mediawiki/php-1.35.0-wmf.15/extensions/Wikibase/client/includes/Api/PageTerms.php(108): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.35.0-wmf.15/extensions/Wikibase/client/includes/Api/PageTerms.php(76): Wikibase\Client\Api\PageTerms->getTermsOfEntities(array, array, string)
#2 /srv/mediawiki/php-1.35.0-wmf.15/includes/api/ApiQuery.php(255): Wikibase\Client\Api\PageTerms->execute()
#3 /srv/mediawiki/php-1.35.0-wmf.15/includes/api/ApiMain.php(1603): ApiQuery->execute()
#4 /srv/mediawiki/php-1.35.0-wmf.15/includes/api/ApiMain.php(539): ApiMain->executeAction()
#5 /srv/mediawiki/php-1.35.0-wmf.15/includes/api/ApiMain.php(510): ApiMain->executeActionWithErrorHandling()
#6 /srv/mediawiki/php-1.35.0-wmf.15/api.php(78): ApiMain->execute()
#7 /srv/mediawiki/w/api.php(3): require(string)
#8 {main}

	Subject	Repo	Branch	Lines +/-
	Fix invalid iteration over false in PageTerms	mediawiki/extensions/Wikibase	wmf/1.35.0-wmf.15	+1 -1
	Fix invalid iteration over false in PageTerms	mediawiki/extensions/Wikibase	master	+1 -1

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	Release	• LarsWirzenius	T233863 1.35.0-wmf.15 deployment blockers
		Resolved	PRODUCTION ERROR	Lucas_Werkmeister_WMDE	T242856 PHP Warning: Invalid argument supplied for foreach()

Event Timeline

• LarsWirzenius created this task.Jan 15 2020, 2:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2020, 2:24 PM

Lucas_Werkmeister_WMDE added projects: Wikidata, Wikidata-Campsite.Jan 15 2020, 2:29 PM

I think this affects any page whose connected item has no aliases; I wrote a query for those, and after opening some of the resulting API URLs, I could see the corresponding warnings with the same URLs in logstash. (That query link searches cawiki, but I also tested it against hewiki, in case the slightly larger error volume on that wikis is also noticeable.)

There's about 120 of these now, and the count is going up. I'm not quite worried enough to make it a train blocker, yet, but it'd be nice to have this looked at anyway.

brennen added a project: User-brennen.Jan 15 2020, 2:43 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.

Addshore claimed this task.Jan 15 2020, 2:44 PM

Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Addshore moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Addshore subscribed.

Restricted Application added a project: User-Addshore. · View Herald TranscriptJan 15 2020, 2:45 PM

Change 565031 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Fix invalid iteration over false in PageTerms

https://gerrit.wikimedia.org/r/565031

gerritbot added a project: Patch-For-Review.Jan 15 2020, 2:46 PM

Some of the count going up was probably my fault, sorry (it took me a while to realize that this is a PHP warning, so I wouldn’t see it in the API output – so I kept making API requests that triggered this for a while ^^)

Change 565034 had a related patch set uploaded (by Addshore; owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.15] Fix invalid iteration over false in PageTerms

https://gerrit.wikimedia.org/r/565034

Moving to our verification column.
The patch is good to be backported to fix the issue for the train.
https://gerrit.wikimedia.org/r/565034

Addshore added a parent task: T233863: 1.35.0-wmf.15 deployment blockers.Jan 15 2020, 2:52 PM

In T242856#5805336, @Addshore wrote:

Moving to our verification column.
The patch is good to be backported to fix the issue for the train.
https://gerrit.wikimedia.org/r/565034

I go deploy this and T242846: Argument 4 passed to WikibaseQuality\ConstraintReport\Specials\SpecialConstraintReport::newFromGlobalState() must be an instance of WikibaseQuality\ConstraintReport\ConstraintCheck\DelegatingConstraintChecker, instance of WikibaseQuality\ConstraintReport\Api\CachingResultsSource given, called in /srv/mediawiki/php-1.35.0-wmf.15/vendor/wikimedia/object-factory/src/ObjectFactory.php on line 172

Change 565031 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Fix invalid iteration over false in PageTerms

https://gerrit.wikimedia.org/r/565031

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jan 15 2020, 3:15 PM

• Pablo-WMDE subscribed.Jan 15 2020, 3:29 PM

Change 565034 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@wmf/1.35.0-wmf.15] Fix invalid iteration over false in PageTerms

https://gerrit.wikimedia.org/r/565034

Mentioned in SAL (#wikimedia-operations) [2020-01-15T15:40:47Z] <ladsgroup@deploy1001> Synchronized php-1.35.0-wmf.15/extensions/Wikibase/client/includes/Api/PageTerms.php: [[gerrit:565034|Fix invalid iteration over false in PageTerms (T242856)]] (duration: 01m 06s)

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.15; 2020-01-14).Jan 15 2020, 4:00 PM

Ladsgroup closed this task as Resolved.Jan 15 2020, 4:00 PM

Ladsgroup moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Maintenance_bot removed a project: Patch-For-Review.Jan 15 2020, 4:10 PM

• LarsWirzenius mentioned this in T242974: PHP Warning: Invalid argument supplied for foreach().Jan 16 2020, 2:36 PM