Make ApiStructureTest work with ParamValidator
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Anomie
	Jan 15 2020, 4:43 PM

Description

ApiStructureTest has a lot of logic for validating the settings arrays in PHPUnit. Some of that logic remains specific to the Action API, but a decent part of it should now be part of the ParamValidator library.

My current thinking is to add a "validateSettings()" method parallel to normalizeSettings(), which will will return a MessageValue[1] if validation fails. ApiStructureTest would call this and fail with the appropriate message.

[1]: Or an array of MessageValues? Or make a Message-library version of Status/StatusValue?

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+2 K -523	Move some validation logic from ApiStructureTest to ParamValidator

Customize query in gerrit

Related Objects

Mentioned In: T244296: ApiStructureTest::testParameters validation failing for flagged revs review module
Mentioned Here: T244296: ApiStructureTest::testParameters validation failing for flagged revs review module

Event Timeline

Anomie created this task.Jan 15 2020, 4:43 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2020, 4:43 PM

Anomie moved this task from Backlog to Doing on the Platform Team Workboards (Green) board.Jan 15 2020, 4:44 PM

Anomie claimed this task.Jan 15 2020, 9:07 PM

Change 565685 had a related patch set uploaded (by Anomie; owner: Anomie):
[mediawiki/core@master] Move some validation logic from ApiStructureTest to ParamValidator

https://gerrit.wikimedia.org/r/565685

gerritbot added a project: Patch-For-Review.Jan 17 2020, 7:29 PM

Anomie moved this task from Doing to Waiting for Review on the Platform Team Workboards (Green) board.Jan 22 2020, 6:14 PM

Change 565685 merged by jenkins-bot:
[mediawiki/core@master] Move some validation logic from ApiStructureTest to ParamValidator

https://gerrit.wikimedia.org/r/565685

Maintenance_bot removed a project: Patch-For-Review.Feb 4 2020, 9:10 PM

Anomie closed this task as Resolved.Feb 4 2020, 9:11 PM