Page MenuHomePhabricator
Create Task
Maniphest T242920

Adapt RTB to new yaml release config
Closed, ResolvedPublic
Actions

Description

We used make-wmf-branch/config.json to determine which repositories to process, but this has been deprecated (and, luckily, renamed so that RTB broke and I actually noticed this)

https://phabricator.wikimedia.org/diffusion/MREL/browse/master/make-wmf-branch/config.json-deprecated

is now

https://phabricator.wikimedia.org/diffusion/MREL/browse/master/make-release/settings.yaml

For now I have hotpatched the bot to use a local copy of the deprecated json file, but we should convert soon-ish. I *think* the new wmf_core group is what we need.

It might be possible as well to reuse some of the Python codebase in make-release which parses the json file.

Details

SubjectRepoBranchLines +/-
Use wikimediaci_utils library to get list of deployed repositorieslabs/tools/forrestbotmaster+3 -11
Customize query in gerrit

Event Timeline

valhallasw created this task.Jan 15 2020, 10:18 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 15 2020, 10:18 PM
Jdforrester-WMF added a comment.Jan 15 2020, 10:23 PM

Oh, oops, I didn't know RTB used this file. :-)

Jdforrester-WMF added a comment.Jan 15 2020, 10:24 PM

(Yes, wmf_core is Wikimedia production, base is the MediaWiki release tarball.)

Legoktm subscribed.Jan 16 2020, 1:01 AM

It might be possible as well to reuse some of the Python codebase in make-release which parses the json file.

We can use https://gerrit.wikimedia.org/r/plugins/gitiles/integration/utils/+/master/wikimediaci_utils/__init__.py#62 (published on pypi as wikimediaci-utils) ... but I need to update that library now.

gerritbot added a comment.Jan 17 2020, 9:23 AM

Change 565515 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[labs/tools/forrestbot@master] Use wikimediaci_utils library to get list of deployed repositories

https://gerrit.wikimedia.org/r/565515

gerritbot added a project: Patch-For-Review.Jan 17 2020, 9:23 AM
gerritbot added a comment.Jan 19 2020, 12:15 PM

Change 565515 merged by jenkins-bot:
[labs/tools/forrestbot@master] Use wikimediaci_utils library to get list of deployed repositories

https://gerrit.wikimedia.org/r/565515

valhallasw closed this task as Resolved.Jan 19 2020, 12:18 PM
valhallasw claimed this task.

Thanks, deployed!

Maintenance_bot removed a project: Patch-For-Review.Jan 19 2020, 1:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL