Page MenuHomePhabricator

Fix flaky test: Homepage can be disabled and re-enabled for new user
Closed, ResolvedPublic


Seen in

09:12:25 5 passing (19.90s)
09:12:25 1 failing
09:12:25 1) Homepage can be disabled and re-enabled for new user:
09:12:25 The expression evaluated to a falsy value:
09:12:25   assert( !HomepagePage.homepage.isExisting() )

A "recheck" resulted in this test passing again.

Event Timeline

Change 565234 had a related patch set uploaded (by Kosta Harlan; owner: Kosta Harlan):
[mediawiki/extensions/GrowthExperiments@master] Disable flaky Selenium test

Change 565234 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Disable flaky Selenium test

kostajh added a subscriber: zeljkofilipin.

I think this could use the same pattern as, where we use browser.waitUntil() to make sure the preference is saved before proceeding. @zeljkofilipin, what do you think?

I'm also OK to delete this test, as I don't think it gains us much in guarding against regressions or testing functionality.

@kostajh I'm fine with both. If you're not sure if the test is valuable, I would vote for it being deleted. Especially if it's flaky.

kostajh claimed this task.

It looks like the test was already deleted, so, I'm closing this task.