Page MenuHomePhabricator
Create Task
Maniphest T242972

mediawiki/mediawiki-codesniffer >= 28 causing travis failures in repos which still think they support PHP < 7.2
Closed, DeclinedPublic
Actions

Description

Noticed on wikimedia/xmp-reader, as it still supports PHP >= 5.6.99, testing on 7.0, 7.1 and hhvm. mediawiki/mediawiki-codesniffer >= 28 needs PHP 7.2

https://travis-ci.org/wikimedia/xmp-reader/builds/601743715

Problem 1
  - Installation request for mediawiki/mediawiki-codesniffer 28.0.0 -> satisfiable by mediawiki/mediawiki-codesniffer[v28.0.0].
  - v28.0.0 requires php >= 7.2.0 -> your PHP version (7.0.33) does not satisfy that requirement.

Related Objects

Event Timeline

Reedy created this task.Jan 16 2020, 2:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 16 2020, 2:01 PM
Reedy added a comment.Jan 16 2020, 2:02 PM

https://gerrit.wikimedia.org/r/#/c/mediawiki/libs/XMPReader/+/565273 tidies it up for one library

Reedy added a comment.Jan 16 2020, 2:03 PM

I guess this is kind of a bug in PHPCS bumping... There's not much point bumping PHPCS version if the php version causes a conflict...

Reedy mentioned this in T230960: Add GPano attribute reading to XMP reader.Jan 16 2020, 2:05 PM
Jdforrester-WMF subscribed.Jan 16 2020, 3:10 PM
In T242972#5809257, @Reedy wrote:

I guess this is kind of a bug in PHPCS bumping... There's not much point bumping PHPCS version if the php version causes a conflict...

Mostly this is just flagging that I need to drop 7.1 and below support from XMPReader.

Reedy added a comment.Jan 16 2020, 3:10 PM
In T242972#5809564, @Jdforrester-WMF wrote:
In T242972#5809257, @Reedy wrote:

I guess this is kind of a bug in PHPCS bumping... There's not much point bumping PHPCS version if the php version causes a conflict...

Mostly this is just flagging that I need to drop 7.1 and below support from XMPReader.

And I suspect numerous other libraries too suffered a similar fate

Jdforrester-WMF added a comment.Jan 16 2020, 4:27 PM
In T242972#5809569, @Reedy wrote:
In T242972#5809564, @Jdforrester-WMF wrote:
In T242972#5809257, @Reedy wrote:

I guess this is kind of a bug in PHPCS bumping... There's not much point bumping PHPCS version if the php version causes a conflict...

Mostly this is just flagging that I need to drop 7.1 and below support from XMPReader.

And I suspect numerous other libraries too suffered a similar fate

https://github.com/search?q=org%3Awikimedia+%27hhvm-3.18%27&type=Code doesn't have many hits. Will go kill some off.

Umherirrender subscribed.Jan 16 2020, 5:54 PM

libup has also a list of php in the required field of composer: https://libraryupgrader2.wmflabs.org/library/composer/php

Reedy added a comment.Jan 16 2020, 5:58 PM
In T242972#5810221, @Umherirrender wrote:

libup has also a list of php in the required field of composer: https://libraryupgrader2.wmflabs.org/library/composer/php

That's a little buggy. ">= version" and ">=version" aren't grouped together

Jdforrester-WMF renamed this task from mediawiki/mediawiki-codesniffer >= 28 causing travis failures in libraries to mediawiki/mediawiki-codesniffer >= 28 causing travis failures in repos which still think they support PHP < 7.2.Jan 17 2020, 12:54 AM
DannyS712 added projects: PHP 7.0 support, PHP 7.1 support.Mar 19 2020, 5:23 PM
Umherirrender unsubscribed.Feb 27 2021, 12:27 PM
Krinkle closed this task as Declined.Apr 13 2022, 1:19 AM
Krinkle subscribed.

We no longer run our tests on Travis.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits