In the parent task, efforts are being made to reduce reading of $wgUser in favor of accessing the request context.
Until all reads are removed, however, writing to $wgUser is being kept, since any subsequent reads need to know the correct user.
As a temporary measure, I propose that, when setting the context user, the global $wgUser also be set
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Have RequestContext::setUser write to $wgUser, add temporary override | mediawiki/core | master | +21 -0 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T11968 Reduce use of global and public variables | |||
| Open | None | T159283 Deprecate non-configuration globals | |||
| Open | DannyS712 | T159299 Deprecate and remove $wgUser | |||
| Declined | DannyS712 | T243003 Create method to temporarily override contextuser / wgUser | |||
| Declined | DannyS712 | T243004 RequestContext setUser should also set wgUser |
Change 565360 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Have RequestContext::setUser write to $wgUser, add temporary override
This would also help with methods that currently need to set both context ->setUser and manually set $wgUser, like
@DannyS712: Assuming this task is about MediaWiki-General, hence adding project tag so others can find this task when searching for tasks under that project.
Change 565360 abandoned by DannyS712:
Have RequestContext::setUser write to $wgUser, add temporary override
Reason:
Not a good idea