Page MenuHomePhabricator

PayPal audit: don't send BAD_AUDIT_LINE / missing subscr_id when donation is present in DB
Closed, ResolvedPublic

Description

The vast majority of PayPal audit rows refer to donations we've already recorded via the IPN listener. We currently validate audit file rows before we check for the donations in the database. This means that we squawk whenever PayPal makes an omission, even if that omission doesn't affect our own data integrity. We've been complaining about the missing subscr_ids for years now and they haven't fixed it, so maybe we should lower our expectations and reduce the noise in our inboxes.

Event Timeline

DStrine triaged this task as Medium priority.Aug 4 2020, 9:03 PM

Change 620123 had a related patch set uploaded (by Jgleeson; owner: Jgleeson):
[wikimedia/fundraising/tools@master] Stop throwing exceptions that result in failmail when a Paypal audit row is missing the subscr_id field (mapped from PayPal Reference ID).

https://gerrit.wikimedia.org/r/620123

Change 620123 merged by jenkins-bot:
[wikimedia/fundraising/tools@master] Paypal Audit: Move the check for missing subscription ids to a later stage in the audit process to avoid overthrowing exceptions.

https://gerrit.wikimedia.org/r/620123