Page MenuHomePhabricator

Hide save button if application is in error state
Closed, ResolvedPublic


App already is using the root store getter applicationStatus to decide ErrorWrapper's visibility. Apply the same logic to the button in the primaryAction slot of the header.

This should automatically unlock a part of T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)

Event Timeline

Dev + UX synced that the button should indeed only be hidden for the error state. It should be visible (though possibly disabled) for the initializing and saving state.

Change 566049 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Hide save button on error states

Change 566049 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Hide save button on error states

Charlie_WMDE moved this task from Verification to Done on the Wikidata-Bridge-Sprint-12 board.

looks good from my side. the header jumps but that's because we moved the implementation of this ticket T237518 to step 2 which will resolve the jump so i guess we live with it until then.