App already is using the root store getter applicationStatus to decide ErrorWrapper's visibility. Apply the same logic to the button in the primaryAction slot of the header.
This should automatically unlock a part of T235753: Step 1: Bail-out path for unsupported datatypes (impact: high)
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| bridge: Hide save button on error states | mediawiki/extensions/Wikibase | master | +25 -10 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T228066 Step 1: Error States of Data-Bridge [Tracking] (impact: medium) | |||
| Resolved | • Tonina_Zhelyazkova_WMDE | T235154 show error when editor can't edit the statement because of permission errors on the repository | |||
| Resolved | Michael | T243010 Hide save button if application is in error state |
Dev + UX synced that the button should indeed only be hidden for the error state. It should be visible (though possibly disabled) for the initializing and saving state.
Change 566049 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/Wikibase@master] bridge: Hide save button on error states
Change 566049 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] bridge: Hide save button on error states
@Lydia_Pintscher @Charlie_WMDE This can be witnessed e.g. on https://de.wikipedia.beta.wmflabs.org/wiki/Data-Bridge when clicking the "Problem-Itemlink" bridge link.
looks good from my side. the header jumps but that's because we moved the implementation of this ticket T237518 to step 2 which will resolve the jump so i guess we live with it until then.