Page MenuHomePhabricator

TagMultiselectWidget performs unnecessary validity check in change handler
Closed, ResolvedPublic

Description

When the widget's tags change, onChangeTags toggles the valid state of the widget:

this.toggleValid(
    this.checkValidity() &&
    !( this.hasInput && this.input.getValue() ) // The input must be empty
);

One problem with checking for an empty input here is that the input must be cleared before adding a new tag, or the widget will be set to an invalid state. However, clearing the input first causes problems (T243075).

It seems the check for the empty input was added in order to address T208507, but that bug seems to be solved by checking the above in onInputBlur. We should be able to remove the check from onChangeTags.

Event Timeline

Change 565590 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[oojs/ui@master] TagMultiselectWidget: Remove unnecessary validity check

https://gerrit.wikimedia.org/r/565590

Change 565590 merged by jenkins-bot:
[oojs/ui@master] TagMultiselectWidget: Remove unnecessary validity check

https://gerrit.wikimedia.org/r/565590

Change 566898 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.36.3

https://gerrit.wikimedia.org/r/566898

Change 566898 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.36.3

https://gerrit.wikimedia.org/r/566898

Volker_E edited projects, added OOUI (OOUI-0.36.3); removed OOUI.
Volker_E triaged this task as Medium priority.
dom_walden added a subscriber: dom_walden.

Testing for this was done at the same time as T243075.