Page MenuHomePhabricator
Create Task
Maniphest T243164

Remove Backward compatibility code (MW < 1.33) in the Translate extension
Closed, ResolvedPublic
Actions

Description

Now that Mediawiki 1.34 has been released, we can remove code written to maintain support for MediaWiki < 1.33

We should also update the extension.json to reflect the new requirements.

Details

SubjectRepoBranchLines +/-
Remove B/C code written for MW < 1.33mediawiki/extensions/Translatemaster+18 -62
Customize query in gerrit

Event Timeline

abi_ created this task.Jan 20 2020, 6:12 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 20 2020, 6:12 AM
abi_ renamed this task from Remove Backward compatibility code in the Translate extension to Remove Backward compatibility code (MW < 1.33) in the Translate extension.Jan 20 2020, 6:13 AM
gerritbot added a comment.Jan 20 2020, 6:14 AM

Change 565267 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Remove B/C code written for MW < 1.33

https://gerrit.wikimedia.org/r/565267

gerritbot added a project: Patch-For-Review.Jan 20 2020, 6:14 AM
abi_ triaged this task as Medium priority.Jan 20 2020, 6:17 AM
abi_ moved this task from Backlog to In Review on the Language-Team (Language-2020-January-March) board.

Following patches have been submitted for this,

  1. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/565267
  2. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Translate/+/565230
abi_ moved this task from Backlog to 2020.01 on the MediaWiki Language Extension Bundle board.Jan 20 2020, 6:24 AM
gerritbot added a comment.Jan 20 2020, 4:36 PM

Change 565267 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove B/C code written for MW < 1.33

https://gerrit.wikimedia.org/r/565267

abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2020-January-March) board.Jan 20 2020, 4:56 PM
ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.16; 2020-01-21).Jan 20 2020, 5:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jan 20 2020, 5:10 PM
abi_ closed this task as Resolved.Feb 3 2020, 4:13 AM
abi_ moved this task from Recheck after deployment to Done on the Language-Team (Language-2020-January-March) board.

This has been deployed on various MediaWiki sites for a while. We've not received any reports of any issues.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL