Page MenuHomePhabricator

Remove wfGetMessageCacheStorage
Closed, ResolvedPublic

Description

wfGetMessageCacheStorage is only used to initialize $messageMemc. wfGetMessageCacheStorage states that it retrieves the cache used by the MessageCache, which is available as a service instead. That should be the recommended replacement.

Codesearch indicates the only usage to be $messageMemc, which is to be deprecated in T243175: Deprecate and remove $messageMemc.

Event Timeline

Mainframe98 updated the task description. (Show Details)
Krinkle added a subscriber: Krinkle.EditedFeb 14 2020, 6:46 PM

It was only recently moved to ServiceWiring. The function should be considered "internal" in my opinion and should have been removed as part of 752e7dd707a9.

Feel free to remove anytime. It doesn't need to wait for messageMemc as the definition can easily be inlined until then.

Krinkle renamed this task from Deprecate wfGetMessageCacheStorage to Remove wfGetMessageCacheStorage.Feb 14 2020, 6:46 PM

Change 572309 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/core@master] Remove wfGetMessageCacheStorage

https://gerrit.wikimedia.org/r/572309

Change 572309 merged by jenkins-bot:
[mediawiki/core@master] Remove wfGetMessageCacheStorage

https://gerrit.wikimedia.org/r/572309

Krinkle closed this task as Resolved.Feb 16 2020, 12:19 AM

Thanks!